fix(setup): make sure CAN_INSTALL error page is shown - #62765
Open
joshtrichards wants to merge 1 commit into
Open
fix(setup): make sure CAN_INSTALL error page is shown#62765joshtrichards wants to merge 1 commit into
joshtrichards wants to merge 1 commit into
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
requested review from
icewind1991,
leftybournes,
provokateurin and
salmart-dev
August 1, 2026 15:59
joshtrichards
changed the title
Member
Author
|
/backport to stable34 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
printGuestPage()doesn't terminate after displaying a template. The error page is effectively invisible due to the redirect immediately after.Stop
finishSetup()from redirecting after displaying theCAN_INSTALLcleanup error page, so users see the actionable message.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)