fix(hooks): distinguish empty listener names from wildcards - #62764
Open
joshtrichards wants to merge 3 commits into
Open
fix(hooks): distinguish empty listener names from wildcards#62764joshtrichards wants to merge 3 commits into
joshtrichards wants to merge 3 commits into
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
Replace exception-based removal checks and placeholder assertion counts with explicit invocation assertions. Verify scope and method isolation after each emission, validate named argument forwarding using a reversed callback signature, and ensure listener removal preserves unrelated registrations. Cover wildcard removal semantics for all listeners of an event, all methods within a scope, one method across scopes, and a specific callback across every registration. Assisted-by: Copilot:GPT-5 Signed-off-by: Josh <josh.t.richards@gmail.com>
Add regression coverage for `removeListener()` behavior when scope or method names are empty strings. Verify that empty values are treated as explicit listener names rather than wildcards, while `null` continues to select wildcard removal behavior. Also cover removal of empty methods across scopes and ensure strict matching does not treat non-string values such as `0` as equivalent to string listener names. Assisted-by: Copilot:GPT-5 Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
marked this pull request as ready for review
August 1, 2026 17:53
joshtrichards
requested review from
icewind1991,
leftybournes,
provokateurin and
salmart-dev
and removed request for
a team
August 1, 2026 17:53
joshtrichards
added
3. to review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix listener removal when scopes or methods are empty strings by distinguishing explicit values from
nullwildcards and using strict matching.Strengthen and extend
BasicEmittercoverage for empty scope and method values, wildcard removal, listener isolation, callback removal, and argument forwarding.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)