fix(share-api-controller): add sanity check on canAccessShare for circle share types - #62724
Merged
Merged
Conversation
artonge
requested review from
Altahrim,
come-nc,
leftybournes and
provokateurin
and removed request for
a team
July 31, 2026 10:44
artonge
added
bug
3. to review
CarlSchwan
approved these changes
Jul 31, 2026
share types Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
artonge
force-pushed
the
fix/1209/share-api-contoller-can-access-share
branch
from
July 31, 2026 11:18
6e515f5 to
5479f63
Compare
Collaborator
Author
|
/backport to stable34 |
Collaborator
Author
|
/backport to stable33 |
Collaborator
Author
|
/backport to stable32 |
Collaborator
Author
|
/backport to stable31 |
Collaborator
Author
|
/backport to stable30 |
artonge
enabled auto-merge
July 31, 2026 12:52
Altahrim
approved these changes
Jul 31, 2026
Altahrim
left a comment
Altahrim
left a comment
Collaborator
There was a problem hiding this comment.
I think we can simplify the code
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.