fix(Database): Use real idle-timer to prevent lastInsertId being reset on MariaDB/MySQL - #62697
Merged
Merged
Conversation
DerDreschner
requested review from
Altahrim,
icewind1991,
nickvergessen and
provokateurin
July 30, 2026 13:51
DerDreschner
force-pushed
the
fix/db-connectivity-check-idle-timer
branch
from
July 30, 2026 13:53
25918f0 to
cc69c33
Compare
Contributor
Author
|
/backport to stable34 |
Contributor
Author
|
/backport to stable33 |
Contributor
Author
|
/backport to stable32 |
Contributor
Author
|
/backport to stable31 |
Contributor
Author
|
/backport to stable30 |
Contributor
Author
|
/backport to stable29 |
Contributor
Author
DerDreschner
enabled auto-merge
July 30, 2026 13:59
nickvergessen
approved these changes
Jul 30, 2026
DerDreschner
force-pushed
the
fix/db-connectivity-check-idle-timer
branch
from
July 30, 2026 14:29
cc69c33 to
44692a2
Compare
…set on MariaDB/MySQL The previous implementation of the idle timer runs on a strict 30 second interval and sends a dummy `SELECT` statement to keep the connection open. This generates issues with the `lastInsertId` on long-running tasks (like our CI pipeline), as the MariaDB documentation clearly states: > If the last query wasn't an INSERT or UPDATE statement or if the modified table does not have a column with the AUTO_INCREMENT attribute and LAST_INSERT_ID was not used, this function will return zero. Source: https://mariadb.com/docs/connectors/mariadb-connector-c/api-functions/mysql_insert_id To mitigate that, this commit now uses a real idle-timer per connection instead. Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: David Dreschner <david.dreschner@nextcloud.com>
DerDreschner
force-pushed
the
fix/db-connectivity-check-idle-timer
branch
from
July 30, 2026 14:31
44692a2 to
acf233c
Compare
CarlSchwan
approved these changes
Jul 30, 2026
This was referenced Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The current implementation of the idle timer is based on a strict 30 second interval. This generates issues with the
getLastInsertId()on MariaDB and MySQL database back ends, as the timer fires a dummySELECTstatement to keep the connection open. The documentation of MariaDB clearly states:Source: https://mariadb.com/docs/connectors/mariadb-connector-c/api-functions/mysql_insert_id
In case the idle timer runs between a
INSERTorUPDATEstatement and agetLastInsertId()call (mostlyocccommands or CI runs), the return value will be reset to0which then messes with the further code paths. The resulting errors are diverse and hard to trace back to this issue.To illustrate how diverse the resulting errors are, I let Claude identify some recent failed CI runs that are affected by this mechanism:
Test\Files\Cache\ScannerTest::testFolderFailed asserting that 0 matches expected 705.— children written withparent = 0, DB row had the real idCache::insert()→getLastInsertId(), threaded as$parentIdMemcachedFactory; sibling matrix job green; deterministic repro exists)Test\Share20\DefaultShareProviderTest::testDeleteSingleShareLazyShareNotFoundfromgetShareById()(DefaultShareProvider.php:785)DefaultShareProvider::create()→getLastInsertId()Test\HelperStorageTest::testGetStorageInfoExcludingExtStorageFailed asserting that 0 matches expected 5.— root folder size never writtenScanner::scanChildren()persists size viaCache::update($folderId, …); id 0 →WHERE fileid = 0no‑op, size stays-1Test\AppFramework\Db\QBMapperDBTest::testUpdateDateTime+DefaultShareProviderTest::testGetAccessListCurrentAccessRequiredQBMapper::insert()sets entity id fromgetLastInsertId()Test\Files\ObjectStore\ObjectStoreStorageTest::testMovefalseurn:oid:{fileId}(ObjectStoreStorage.php)OCA\ShareByMail\Tests\ShareByMailProviderTest::testCreateMailShare/::testAddShareToDBShareByMailProvider→getLastInsertId()OCA\Federation\Tests\DbHandlerTest::testAddServerDbHandler::addServer()→getLastInsertId()UserGlobalStoragesServiceTest::testGetUniqueStoragesFailed asserting that an array has the key 0.— the corrupted id is in the messageDBConfigService.php→return $query->getLastInsertId();A possible next step is to remove the idle timer entirely and react on the
ConnectionLostexception instead (see doctrine/dbal#6903) or use a 3rd-party library like https://github.com/facile-it/doctrine-mysql-come-back. Such an approach has additional benefits, as it also works for lost connections during running queries, which might be the reason why the DBAL developers dropped theConnection::ping()method in DBAL 3 (which was affected by this bug as well, fun fact).To make the fix easy to backport, I've focused on a in-place fix for now.
Checklist
3. to review, feature component)stable32)AI (if applicable)