test: resolve potential flaky Playwright tests - #62688
Merged
Merged
Conversation
- UnifiedSearchPage: expose the popover's polite status region and add waitForSettledResults(), which waits for the settled result count. That is the component's own "all providers answered" signal, so no arbitrary delay is needed. activeOptionId() asserts the attribute before reading it so a mid-flight list cannot yield null. - header-unified-search: the three selection-dependent tests settle the search before reading the selection; Enter's navigation is awaited with a pre-armed waitForURL, since the /f/<id> redirect can outlive the default assertion timeout. - admin-settings-limit-to-same-group: create the shared groups once in beforeAll instead of per test, moving two occ round-trips out of each test's timeout. - FilesListPage: bound the previously unbounded waits, so a row or list that never renders fails fast and names the missing element instead of surfacing as a bare test timeout. - playwright.config: allow 1.5x the default test timeout on CI, where the server is shared and every step is slower. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
requested review from
kristian-zendato,
nfebe and
sorbaugh
and removed request for
a team
July 30, 2026 11:03
susnux
added
3. to review
CarlSchwan
approved these changes
Jul 30, 2026
pringelmann
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Another batch of making end-to-end tests less flaky.
When we migrated the tests we also converted some issues in Cypress tests to Playwright, so this solves:
And also fixes some Playwright specific issues:
Checklist
3. to review, feature component)stable32)AI (if applicable)