Skip to content

test: reduce flakyness of files version tests #62627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
susnux wants to merge 1 commit into
base: master
Choose a base branch
from
+16 −4
Open

test: reduce flakyness of files version tests #62627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions tests/playwright/e2e/files_versions/version-cross-share-move-and-copy.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,10 @@ async function copyToRoot(filesListPage: FilesListPage, copyMoveDialog: CopyMove
}

test.describe('files_versions: versions across a share move/copy', () => {
// Every test here seeds a share, boots the files app twice,
// and walks the sidebar, the versions list and the move/copy picker.
test.slow()

test('moves the versions when the file is moved out of a received share', async ({ page, user, owner, ownerRequest, filesListPage, versionsTab, filesSidebar, copyMoveDialog }) => {
await seedSharedVersionedFile(owner, ownerRequest, user, page.request, FILE_NAME)
await nameInitialVersion(filesListPage, versionsTab, SHARED_FOLDER, FILE_NAME)
Expand Down Expand Up @@ -150,8 +154,7 @@ test.describe('files_versions: versions across a share move/copy', () => {
await nameInitialVersion(filesListPage, versionsTab, `${SHARED_FOLDER}/${subFolder}/${subSubFolder}`, FILE_NAME)
await filesSidebar.close()

await filesListPage.open()
await filesListPage.navigateToFolder(SHARED_FOLDER)
await filesListPage.navigateToBreadcrumb(SHARED_FOLDER)
await moveToRoot(filesListPage, copyMoveDialog, subFolder)

await assertVersionsContent(filesListPage, versionsTab, relPath, { expectLabel: true })
Expand All @@ -165,8 +168,7 @@ test.describe('files_versions: versions across a share move/copy', () => {
await nameInitialVersion(filesListPage, versionsTab, `${SHARED_FOLDER}/${subFolder}/${subSubFolder}`, FILE_NAME)
await filesSidebar.close()

await filesListPage.open()
await filesListPage.navigateToFolder(SHARED_FOLDER)
await filesListPage.navigateToBreadcrumb(SHARED_FOLDER)
await copyToRoot(filesListPage, copyMoveDialog, subFolder)

await assertVersionsContent(filesListPage, versionsTab, relPath, { expectLabel: false })
Expand Down
10 changes: 10 additions & 0 deletions tests/playwright/support/sections/FilesListPage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,16 @@ export class FilesListPage {
return this.page.getByRole('navigation', { name: 'Current directory path' })
}

/**
* Navigate to an ancestor of the current folder through the breadcrumb
*
* @param name - The label of the crumb to navigate to
*/
async navigateToBreadcrumb(name: string): Promise<void> {
await this.getBreadcrumbs().getByRole('button', { name, exact: true }).click()
await this.waitForListLoaded()
}

getRowForFile(filename: string): Locator {
return this.page.locator(`[data-cy-files-list-row-name="${escapeAttributeValue(filename)}"]`)
}
Expand Down
Loading