Skip to content

Preparations for files_sharing legacy backend - #62613

Merged
provokateurin merged 10 commits into
masterfrom
refactor/sharing/files_sharing-legacy-backend-preparations
Jul 30, 2026
Merged

Preparations for files_sharing legacy backend#62613
provokateurin merged 10 commits into
masterfrom
refactor/sharing/files_sharing-legacy-backend-preparations

Conversation

@provokateurin

@provokateurin provokateurin commented Jul 28, 2026

Copy link
Copy Markdown
Member

@provokateurin provokateurin added this to the Nextcloud 35 milestone Jul 28, 2026
@provokateurin
provokateurin requested a review from a team as a code owner July 28, 2026 13:49
@provokateurin provokateurin added 3. to review Waiting for reviews ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Jul 28, 2026
@provokateurin
provokateurin requested review from Altahrim, icewind1991, leftybournes and salmart-dev and removed request for a team July 28, 2026 13:49
CarlSchwan
CarlSchwan reviewed Jul 28, 2026
View reviewed changes
Comment thread lib/private/Sharing/ISharingLegacyBackend.php
icewind1991
icewind1991 reviewed Jul 28, 2026
View reviewed changes
Comment thread apps/sharing/lib/Migration/Version1000Date20260721055820.php Outdated
icewind1991
icewind1991 reviewed Jul 28, 2026
View reviewed changes
Comment thread lib/private/Sharing/SharingManager.php Outdated
icewind1991
icewind1991 reviewed Jul 28, 2026
View reviewed changes
Comment thread lib/private/Sharing/SharingManager.php Outdated
icewind1991
icewind1991 reviewed Jul 28, 2026
View reviewed changes
Comment thread lib/private/Sharing/SharingManager.php Outdated
icewind1991
icewind1991 reviewed Jul 28, 2026
View reviewed changes
Comment thread lib/private/Sharing/SharingManager.php Outdated
@provokateurin
provokateurin force-pushed the refactor/sharing/files_sharing-legacy-backend-preparations branch from e8a22a7 to 644333a Compare July 29, 2026 07:27
@provokateurin

provokateurin commented Jul 29, 2026

Copy link
Copy Markdown
Member Author

I've simplified the legacy backend logic a bit, so now there can only be one legacy backend (because we only ever want to use it for files_sharing and nothing else) and therefore the field for storing which legacy backend is used is dropped from the share object and the database.

@provokateurin
provokateurin enabled auto-merge July 29, 2026 09:33
@icewind1991

icewind1991 commented Jul 29, 2026

Copy link
Copy Markdown
Member

rebased

@icewind1991
icewind1991 force-pushed the refactor/sharing/files_sharing-legacy-backend-preparations branch from 644333a to 0ef98e3 Compare July 29, 2026 20:49
@provokateurin @icewind1991
refactor(Sharing): Move SharingBackend to OC
f7be338 
Signed-off-by: provokateurin <kate@provokateurin.de>

# Conflicts:
#	apps/sharing/lib/AppInfo/Application.php
@provokateurin @icewind1991
refactor(Sharing): Always store shares in unified sharing backend and…
8c92be9 
… only use legacy backends to process updates

Signed-off-by: provokateurin <kate@provokateurin.de>

� Conflicts:
�	apps/sharing/lib/AppInfo/Application.php
�	lib/private/Sharing/SharingManager.php
�	lib/private/Sharing/SharingRegistry.php
�	lib/unstable/Sharing/ISharingBackend.php
�	lib/unstable/Sharing/ISharingRegistry.php
@provokateurin @icewind1991
refactor(SharingBackend): Create default values for properties and pe…
f262364 
…rmissions through the SharingManager

Signed-off-by: provokateurin <kate@provokateurin.de>

# Conflicts:
#	lib/unstable/Sharing/ISharingManager.php
@provokateurin @icewind1991
refactor(SharingBackend): Move value initializations to the SharingMa…
fc23c1f 
…nager

Signed-off-by: provokateurin <kate@provokateurin.de>

� Conflicts:
�	lib/private/Sharing/SharingBackend.php
�	lib/private/Sharing/SharingManager.php
@provokateurin @icewind1991
fix(Share20): Pass previous exception if exception occurred during sh…
ec8f046 
…are interaction check

Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin @icewind1991
fix(Share20): Only set random token if no token is set
463a1e2 
Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin @icewind1991
fix(Share20): Use correct enum for share type
25f698b 
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin and others added 3 commits July 30, 2026 01:01
@provokateurin @icewind1991
fix(Share20): Use correct enum for share status
acec9da 
Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin @icewind1991
fix(Share20): Use correct enum for share permissions
5bb204c 
Signed-off-by: provokateurin <kate@provokateurin.de>
@icewind1991
chore: fix ncu @experimental
f7ecd25 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
icewind1991 force-pushed the refactor/sharing/files_sharing-legacy-backend-preparations branch from 7b5084c to f7ecd25 Compare July 29, 2026 23:01
@provokateurin
provokateurin merged commit c65d1f9 into master Jul 30, 2026
227 of 229 checks passed
@provokateurin
provokateurin deleted the refactor/sharing/files_sharing-legacy-backend-preparations branch July 30, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@icewind1991 icewind1991 icewind1991 approved these changes
@CarlSchwan CarlSchwan CarlSchwan approved these changes
@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend
@salmart-dev salmart-dev Awaiting requested review from salmart-dev salmart-dev is a code owner automatically assigned from nextcloud/server-backend
@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Milestone

Nextcloud 35

Development

Successfully merging this pull request may close these issues.

3 participants

@provokateurin @icewind1991 @CarlSchwan