feat(core): show real per-result icons in unified search - #62605
Draft
pringelmann wants to merge 2 commits into
Draft
feat(core): show real per-result icons in unified search#62605pringelmann wants to merge 2 commits into
pringelmann wants to merge 2 commits into
Conversation
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reworks how unified search presents results, per the design in #61652.
The aggregate list now shows at most three rows per category, each group headed by a "More from …" control that opens that category's full result page in a detail view. Result rows show their provider's real icon instead of a generic one.
Smaller fixes from the same pass:
instead of flashing an empty panel.
and the resting empty state no longer carry a blank padded strip.
SectionSearchnow uses each settings section's own icon. That reverses an older workaround whose comment noted those icons did not invert for dark theme; the newAppIconcomponent handles the inversion, so the icon URL is safe to use again.Design feedback already captured
The following feedback items were already captured. They will land in a follow-up PR: I want to get the core work merged, then we iterate.
Also see screenshot: the PDF filetype icon is too small and also blue
Checklist
3. to review, feature component)stable32)AI (if applicable)