Skip to content

fix(taskprocessing): AppAPI webhook error handling #62597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
joshtrichards wants to merge 3 commits into
base: master
Choose a base branch
from
+107 −34
Draft

fix(taskprocessing): AppAPI webhook error handling #62597

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
946f94c
fix(taskprocessing): return on malformed AppAPI webhook method
joshtrichards Jul 27, 2026
ac1fd94
fix(taskprocessing): pass AppAPI webhook errors as logger context
joshtrichards Jul 27, 2026
c6202ce
chore: tidy up runWebhook formatting
joshtrichards Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
141 changes: 107 additions & 34 deletions lib/private/TaskProcessing/Manager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1938,47 +1938,120 @@ private function runWebhook(Task $task): void {
]),
'headers' => ['Content-Type' => 'application/json'],
];

try {
$client->request($httpMethod, $uri, $options);
} catch (ClientException|ServerException $e) {
$this->logger->warning('Task processing HTTP webhook failed for task ' . $task->getId() . '. Request failed', ['exception' => $e]);
$this->logger->warning(
'Task processing HTTP webhook failed for task ' . $task->getId() . '. Request failed',
['exception' => $e],
);
} catch (\Exception|\Throwable $e) {
$this->logger->warning('Task processing HTTP webhook failed for task ' . $task->getId() . '. Unknown error', ['exception' => $e]);
}
} elseif (str_starts_with($method, 'AppAPI:') && str_starts_with($uri, '/')) {
$parsedMethod = explode(':', $method, 4);
if (count($parsedMethod) < 3) {
$this->logger->warning('Task processing AppAPI webhook failed for task ' . $task->getId() . '. Invalid method: ' . $method);
}
[, $exAppId, $httpMethod] = $parsedMethod;
if (!$this->appManager->isEnabledForAnyone('app_api')) {
$this->logger->warning('Task processing AppAPI webhook failed for task ' . $task->getId() . '. AppAPI is disabled or not installed.');
return;
}
try {
$appApiFunctions = Server::get(PublicFunctions::class);
} catch (ContainerExceptionInterface|NotFoundExceptionInterface) {
$this->logger->warning('Task processing AppAPI webhook failed for task ' . $task->getId() . '. Could not get AppAPI public functions.');
return;
$this->logger->warning(
'Task processing HTTP webhook failed for task ' . $task->getId() . '. Unknown error',
['exception' => $e],
);
}
$exApp = $appApiFunctions->getExApp($exAppId);
if ($exApp === null) {
$this->logger->warning('Task processing AppAPI webhook failed for task ' . $task->getId() . '. ExApp ' . $exAppId . ' is missing.');
return;
} elseif (!$exApp['enabled']) {
$this->logger->warning('Task processing AppAPI webhook failed for task ' . $task->getId() . '. ExApp ' . $exAppId . ' is disabled.');
return;
}
$requestParams = [
'task' => $task->jsonSerialize(),
];
$requestOptions = [
'timeout' => 30,
];
$response = $appApiFunctions->exAppRequest($exAppId, $uri, $task->getUserId(), $httpMethod, $requestParams, $requestOptions);

return;
}

if (!str_starts_with($method, 'AppAPI:') || !str_starts_with($uri, '/')) {
return;
}

$parsedMethod = explode(':', $method, 4);
if (
count($parsedMethod) !== 3
|| $parsedMethod[1] === ''
|| !in_array($parsedMethod[2], ['GET', 'POST', 'PUT', 'DELETE'], true)
) {
$this->logger->warning(
'Task processing AppAPI webhook failed for task '
. $task->getId()
. '. Invalid method: '
. $method,
);
return;
}

[, $exAppId, $httpMethod] = $parsedMethod;

if (!$this->appManager->isEnabledForAnyone('app_api')) {
$this->logger->warning(
'Task processing AppAPI webhook failed for task '
. $task->getId()
. '. AppAPI is disabled or not installed.',
);
return;
}

try {
$appApiFunctions = Server::get(PublicFunctions::class);
} catch (ContainerExceptionInterface|NotFoundExceptionInterface) {
$this->logger->warning(
'Task processing AppAPI webhook failed for task '
. $task->getId()
. '. Could not get AppAPI public functions.',
);
return;
}

$exApp = $appApiFunctions->getExApp($exAppId);
if ($exApp === null) {
$this->logger->warning(
'Task processing AppAPI webhook failed for task '
. $task->getId()
. '. ExApp '
. $exAppId
. ' is missing.',
);
return;
}

if (!$exApp['enabled']) {
$this->logger->warning(
'Task processing AppAPI webhook failed for task '
. $task->getId()
. '. ExApp '
. $exAppId
. ' is disabled.',
);
return;
}

$requestParams = [
'task' => $task->jsonSerialize(),
];
$requestOptions = [
'timeout' => 30,
];

try {
$response = $appApiFunctions->exAppRequest(
$exAppId,
$uri,
$task->getUserId(),
$httpMethod,
$requestParams,
$requestOptions,
);

if (is_array($response) && isset($response['error'])) {
$this->logger->warning('Task processing AppAPI webhook failed for task ' . $task->getId() . '. Error during request to ExApp(' . $exAppId . '): ', $response['error']);
$this->logger->warning(
'Task processing AppAPI webhook failed for task '
. $task->getId()
. '. Error during request to ExApp('
. $exAppId
. ').',
['error' => $response['error']],
);
}
} catch (\Throwable $e) {
$this->logger->warning(
'Task processing AppAPI webhook failed for task ' . $task->getId() . '. Request failed.',
['exception' => $e],
);
}
}
}
Loading