feat(files_sharing): unified sharing dialog in the sidebar (killswitched) - #62593
Draft
skjnldsv wants to merge 3 commits into
Draft
feat(files_sharing): unified sharing dialog in the sidebar (killswitched)#62593skjnldsv wants to merge 3 commits into
skjnldsv wants to merge 3 commits into
Conversation
Add a hidden appconfig `files_sharing sharing_dialog_enabled` (BOOL, default true) surfaced to the sidebar via initial state. When enabled the sidebar uses the new unified sharing dialog; setting it to false temporarily restores the legacy inline sharing UI. Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Gated by the sharing_dialog_enabled killswitch (default on): - SharingTab: hide both legacy SharingInputs, add a single Share button that opens the new dialog to create a share. - SharingEntry (internal): replace the details 3-dots button with an Edit + Delete dual button and hide the quick-share permission select. - SharingEntryLink: hide the quick-share select and route Customize link to the new dialog. Edit opens the share in the new dialog by id (resolved via the upcoming legacy->unified bridge). The legacy UI stays intact behind the killswitch. Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
The new Delete dual-button deleted immediately. Add a confirmation dialog so the destructive action is not one accidental click away. Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP