fix(iMIP): Prevent mails from carrying an unrelated user's name - #62580
Open
DerDreschner wants to merge 1 commit into
Open
fix(iMIP): Prevent mails from carrying an unrelated user's name#62580DerDreschner wants to merge 1 commit into
DerDreschner wants to merge 1 commit into
Conversation
Contributor
Author
|
/backport to stable34 |
Contributor
Author
|
/backport to stable33 |
Contributor
Author
|
/backport to stable32 |
DerDreschner
marked this pull request as ready for review
July 27, 2026 12:26
DerDreschner
requested review from
a team,
ChristophWurst,
SebastianKrupinski and
tcitworld
as code owners
July 27, 2026 12:26
DerDreschner
requested review from
come-nc,
leftybournes,
provokateurin and
salmart-dev
and removed request for
a team
July 27, 2026 12:26
DerDreschner
enabled auto-merge
July 27, 2026 13:16
Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: David Dreschner <david.dreschner@nextcloud.com>
DerDreschner
force-pushed
the
fix/prevent-imip-sender-leak
branch
from
July 28, 2026 14:08
35a2ff6 to
13acc22
Compare
Contributor
|
Hey, I had a quick look and read and I think we are going to have to make this change further down in the schedule() function, there are two sending code paths, one for sending via system mail the other using mail provider (user own email address) When sending using the mail provider we use the email address that is original provided in the event to match a email account in the mail provider. So it should be: System mail -> Set display name -> Set reply to address |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue in the iMIP component of Nextcloud.
When the iTip message contains no (optional)
CNproperty for the person we're sending the iMIP message on behalf of, we're using the display name of the current session user to fill out the sender for iMIP messages. This means we're sending out mails with the correct mail address, but wrong display name. Example how it's sent out right now, although it should say "A":This is especially the case when using Thunderbird, as it doesn't set the
CNproperty.To solve the issue, this PR implements the following steps:
From: "Nextcloud" <noreply...>; Reply-To: <a@test.example>Checklist
3. to review, feature component)stable32)AI (if applicable)