perf: Ensure encryption wrapper is only setup when needed - #62551
Draft
CarlSchwan wants to merge 2 commits into
Draft
perf: Ensure encryption wrapper is only setup when needed#62551CarlSchwan wants to merge 2 commits into
CarlSchwan wants to merge 2 commits into
Conversation
The app needs to be enabled and the settings need to be on. Signed-off-by: Carl Schwan <carl@carlschwan.eu>
- Port to IAppConfig - Port to IRootFolder - Add typing - Add Consumable attribute to OCP interface Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
added
3. to review
CarlSchwan
requested review from
come-nc,
leftybournes,
provokateurin and
salmart-dev
and removed request for
a team
July 27, 2026 08:08
provokateurin
approved these changes
Jul 27, 2026
susnux
approved these changes
Jul 27, 2026
CarlSchwan
marked this pull request as draft
July 27, 2026 18:40
Member
Author
|
Failure is related |
artonge
reviewed
Jul 28, 2026
| @@ -206,7 +206,7 @@ public function getDefaultEncryptionModuleId() { | |||
| */ | |||
| public function setupStorage(): void { | |||
| // If encryption is disabled and there are no loaded modules it makes no sense to load the wrapper | |||
| if (!empty($this->encryptionModules) || $this->isEnabled()) { | |||
| if ($this->encryptionModules !== [] && $this->isEnabled()) { | |||
Collaborator
There was a problem hiding this comment.
cc. @come-nc as I recall that this is on purpose in case encryption was disabled without decrypting all files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The app needs to be enabled and the settings need to be on.
And second commit
refactor: Cleanup encryption manager
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)