fix: Use PHP_AUTH_PW for strict password confirmation - #62477
Merged
SystemKeeper merged 2 commits intoJul 29, 2026
Conversation
SystemKeeper
force-pushed
the
fix/62362/password-confirmation-php-auth-pw
branch
from
July 24, 2026 11:54
38fb22e to
eebb3a2
Compare
SystemKeeper
marked this pull request as ready for review
July 24, 2026 12:37
SystemKeeper
requested review from
Altahrim,
leftybournes,
provokateurin and
salmart-dev
and removed request for
a team
July 24, 2026 12:37
Contributor
Author
|
/backport! to stable34 |
3 tasks
provokateurin
approved these changes
Jul 27, 2026
Comment on lines
+229
to
+236
| $thrown = false; | ||
| try { | ||
| $this->middleware->beforeController($this->controller, __FUNCTION__); | ||
| } catch (NotConfirmedException) { | ||
| $thrown = true; | ||
| } | ||
|
|
||
| $this->assertSame(false, $thrown); |
Member
There was a problem hiding this comment.
Can be simplified to just call the method without a catch and assertion.
Contributor
Author
There was a problem hiding this comment.
I was just following the schema that is used in the file already.
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
SystemKeeper
force-pushed
the
fix/62362/password-confirmation-php-auth-pw
branch
from
July 29, 2026 16:44
eebb3a2 to
07e123e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We already make sure that
AUTHORIZATIONheaders are copied toPHP_AUTH_USERandPHP_AUTH_PW, so these should work in all cases.server/lib/OC.php
Lines 1297 to 1318 in 3541356
Please check if there's any reason to access the raw authorization header in that method, in that case we could use the
PHP_AUTH_*ones as fallback.Checklist
3. to review, feature component)stable32)AI (if applicable)