Skip to content

Bump sabre dav to 4.7.1 - #62405

Open
CarlSchwan wants to merge 3 commits into
masterfrom
3rdparty/dependabot/composer/master/sabre/dav-4.7.1
Open

Bump sabre dav to 4.7.1#62405
CarlSchwan wants to merge 3 commits into
masterfrom
3rdparty/dependabot/composer/master/sabre/dav-4.7.1

Conversation

@CarlSchwan

Copy link
Copy Markdown
Member

Summary

See nextcloud/3rdparty#2526

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@CarlSchwan CarlSchwan added this to the Nextcloud 35 milestone Jul 22, 2026
@CarlSchwan CarlSchwan self-assigned this Jul 22, 2026
@CarlSchwan
CarlSchwan requested a review from a team as a code owner July 22, 2026 11:31
@CarlSchwan
CarlSchwan requested review from Altahrim, icewind1991, leftybournes and salmart-dev and removed request for a team July 22, 2026 11:31
@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label Jul 22, 2026
@CarlSchwan
CarlSchwan force-pushed the 3rdparty/dependabot/composer/master/sabre/dav-4.7.1 branch 4 times, most recently from 1a5d001 to 4f22769 Compare July 22, 2026 16:04
@joshtrichards joshtrichards changed the title Bump sabre dav to 3.7.1 Bump sabre dav to 4.7.1 Jul 22, 2026
CarlSchwan and others added 3 commits July 24, 2026 19:15
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb
kesselb force-pushed the 3rdparty/dependabot/composer/master/sabre/dav-4.7.1 branch from 4f22769 to f8c7b3d Compare July 24, 2026 17:15
@kesselb
kesselb requested a review from Copilot July 24, 2026 17:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Nextcloud’s DAV integration and test fixtures to align with the newer Sabre DAV/VObject behavior expected after the dependency bump referenced in nextcloud/3rdparty.

Changes:

  • Update multiple ICS/VCF fixtures and calendar test XML payloads to the new Sabre VObject PRODID version string.
  • Adjust Sabre connector method signatures (ObjectTree::copy, Directory::copyInto) to match the updated Sabre DAV APIs that include a depth argument.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/lib/Calendar/ManagerTest.php Updates expected VCALENDAR PRODID in free/busy responses.
tests/data/ics/free-busy-request.ics Updates fixture PRODID string.
tests/data/ics/event-builder-without-attendees.ics Updates fixture PRODID string.
tests/data/ics/event-builder-complete.ics Updates fixture PRODID string.
apps/dav/tests/unit/test_fixtures/example-event-default-expected.ics Updates fixture PRODID string used by DAV unit tests.
apps/dav/lib/ExampleContentFiles/exampleContact.vcf Updates example VCF PRODID string.
apps/dav/lib/Connector/Sabre/ObjectTree.php Updates copy() signature to accept depth (but currently does not use it).
apps/dav/lib/Connector/Sabre/Directory.php Updates copyInto() signature to accept depth (but currently does not use it).
Comments suppressed due to low confidence (1)

apps/dav/lib/Connector/Sabre/ObjectTree.php:162

  • The new $depth argument is currently ignored. For WebDAV COPY on collections, Depth: 0 vs infinity changes semantics; always performing a recursive copy can violate the request and Sabre\DAV's expectations after the signature change.
	public function copy($sourcePath, $destinationPath, int $depth = Server::DEPTH_INFINITY): void {
		if (!$this->fileView) {
			throw new \Sabre\DAV\Exception\ServiceUnavailable('filesystem not setup');
		}


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


#[\Override]
public function copyInto($targetName, $sourcePath, INode $sourceNode) {
public function copyInto($targetName, $sourcePath, INode $sourceNode, int $depth): bool {
@kesselb

kesselb commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Should we update the existing beforeCopy / afterCopy listeners for the new depth argument?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews AI assisted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants