feat(files_sharing): fetch remote avatars for external shares - #62355
Open
leftybournes wants to merge 6 commits into
Open
feat(files_sharing): fetch remote avatars for external shares#62355leftybournes wants to merge 6 commits into
leftybournes wants to merge 6 commits into
Conversation
leftybournes
added
enhancement
3. to review
leftybournes
requested review from
Altahrim,
come-nc,
nfebe and
salmart-dev
and removed request for
a team
July 21, 2026 05:35
leftybournes
force-pushed
the
leftybournes/feat/federatedshares-show-avatars
branch
from
July 21, 2026 05:47
e064efd to
b8f517f
Compare
leftybournes
force-pushed
the
leftybournes/feat/federatedshares-show-avatars
branch
2 times, most recently
from
July 21, 2026 06:20
5f1c880 to
a17c574
Compare
provokateurin
requested changes
Jul 21, 2026
Comment on lines
+69
to
+72
| $contentType = $response->getHeader('Content-Type'); | ||
| if ($contentType !== 'image/png') { | ||
| throw new \Exception('Unknown filetype'); | ||
| } |
Member
There was a problem hiding this comment.
That seems a bit strict. If a user uploads their own avatar it is probably stored and served in the original format.
Member
Author
There was a problem hiding this comment.
I modified it to also check for jpgs
Member
There was a problem hiding this comment.
There are a lot more formats that people actually use. Maybe just limit the check to ensure the mimetype starts with image/?
Member
Author
There was a problem hiding this comment.
That makes sense and it makes the check easier. Just pushed the change.
CarlSchwan
reviewed
Jul 21, 2026
leftybournes
force-pushed
the
leftybournes/feat/federatedshares-show-avatars
branch
from
July 22, 2026 08:54
a17c574 to
318668e
Compare
Signed-off-by: Kent Delante <kent@delante.me> Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: Kent Delante <kent@delante.me> Assisted-by: ClaudeCode:claude-sonnet-5
leftybournes
force-pushed
the
leftybournes/feat/federatedshares-show-avatars
branch
from
July 23, 2026 02:33
318668e to
7551692
Compare
CarlSchwan
reviewed
Jul 28, 2026
CarlSchwan
approved these changes
Jul 28, 2026
Member
|
failing tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently, external shares always show a
GuestAvatarin the files list. This adds functionality to fetch the remote sharer's avatar.Checklist
3. to review, feature component)stable32)AI (if applicable)