Skip to content

feat(activity): Adding sample config for new activity options - #62230

Open
Aiiaiiio wants to merge 1 commit into
masterfrom
chore/adding-docs-for-new-activity-option
Open

feat(activity): Adding sample config for new activity options#62230
Aiiaiiio wants to merge 1 commit into
masterfrom
chore/adding-docs-for-new-activity-option

Conversation

@Aiiaiiio

Copy link
Copy Markdown
  • Resolves: -

Summary

Added Activity config values to sample config.

TODO

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: Tamás Bari <adaorcpp@gmail.com>
Copilot AI review requested due to automatic review settings July 16, 2026 09:09
@Aiiaiiio
Aiiaiiio requested a review from a team as a code owner July 16, 2026 09:09
@Aiiaiiio
Aiiaiiio requested review from Altahrim, come-nc, leftybournes, miaulalala and nfebe and removed request for a team July 16, 2026 09:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.

Adds documentation for new Activity-related configuration options to the sample configuration, helping admins discover and correctly set these options.

Changes:

  • Documented activity_expire_exclude_users for excluding specific users from activity expiration.
  • Documented activity_log_exclude_users for per-user activity event-type logging exclusions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread config/config.sample.php
Comment on lines +1407 to +1409
* Defaults to ``[]``
*/
'activity_expire_exclude_users' => [],
Comment thread config/config.sample.php
Comment on lines +1423 to +1425
* Defaults to ``[]``
*/
'activity_log_exclude_users' => [],
Comment thread config/config.sample.php
Comment on lines +1412 to +1421
* Per-user activity logging exclusions.
*
* An associative array mapping user IDs to an array of event type strings.
* Activities of the listed event types will not be logged for the
* corresponding user. For example::
*
* 'activity_log_exclude_users' => [
* 'alice' => ['file_created'],
* 'bob' => ['file_created', 'file_changed'],
* ],
Comment thread config/config.sample.php
Comment on lines +1395 to +1397
/**
* Users excluded from activity expiration.
*

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would add "Reqires acitivty app" or similar to ensure admins know this is for the activity app

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these options are under a higher level group

/**
 * Activity
 *
 * Options for the activity app.
 */

(see line 1354)

I can add that extra line but then it will be inconsistent, so I should add it to all. Then, the Activity section will be inconsistent with others, etc-etc ... feels like a rabbit hole.

@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants