fix: enhance name splitting to handle "Lastname, Firstname" format - #62122
Open
enjeck wants to merge 2 commits into
Open
fix: enhance name splitting to handle "Lastname, Firstname" format#62122enjeck wants to merge 2 commits into
enjeck wants to merge 2 commits into
Conversation
enjeck
force-pushed
the
fix/comma-seperated-names
branch
3 times, most recently
from
July 14, 2026 18:58
ec835f7 to
5437266
Compare
Contributor
|
How does it cover cases like this?
|
enjeck
force-pushed
the
fix/comma-seperated-names
branch
from
July 23, 2026 08:28
5437266 to
9a3b882
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
|
More or less that was implemented on Talk client side: https://github.com/nextcloud/spreed/pull/18682/changes Might be an overkill, but basics to match would be:
|
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
enjeck
force-pushed
the
fix/comma-seperated-names
branch
from
July 24, 2026 01:04
b28fbb6 to
5581ee3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If an ActiveDirectory provides user names in the "Lastname, Firstname" format, Nextcloud attempts to split this string internally, but it maps the values the wrong way around.
This becomes very obvious in the Contacts app, where the "First name" field is incorrectly populated with the user's last name including the comma (e.g., "Lastname,"), and the "Last name" field contains the user's actual first name
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)