Skip to content

fix(files_sharing): only offer folders in file-request which are shareable #62113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
susnux wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(files_sharing): only offer folders in file-request which are shareable #62113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion apps/files_sharing/src/components/NewFileRequestDialog.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,11 +197,14 @@ export default defineComponent({
},

data() {
const destination = (this.context.permissions & Permission.SHARE)
? this.context.path
: '/'
return {
currentStep: STEP.FIRST,
loading: false,

destination: this.context.path || '/',
destination,
label: '',
note: '',

Expand Down
6 changes: 4 additions & 2 deletions apps/files_sharing/src/components/NewFileRequestDialog/NewFileRequestDialogIntro.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,11 @@
</template>

<script lang="ts">
import type { Folder, Node } from '@nextcloud/files'
import type { Folder, INode } from '@nextcloud/files'
import type { PropType } from 'vue'

import { getFilePickerBuilder } from '@nextcloud/dialogs'
import { Permission } from '@nextcloud/files'
import { t } from '@nextcloud/l10n'
import { defineComponent } from 'vue'
import NcTextArea from '@nextcloud/vue/components/NcTextArea'
Expand Down Expand Up @@ -146,6 +147,7 @@ export default defineComponent({
callback: this.onPickedDestination,
})
.setFilter((node) => node.path !== '/')
.setCanPick((node) => Boolean(node.permissions & Permission.SHARE))
.startAt(this.destination)
.build()
try {
Expand All @@ -155,7 +157,7 @@ export default defineComponent({
}
},

onPickedDestination(nodes: Node[]) {
onPickedDestination(nodes: INode[]) {
const node = nodes[0]
if (node) {
this.$emit('update:destination', node.path)
Expand Down
Loading