Skip to content

fix(encryption): bind personal private key password inputs - #62027

Merged
susnux merged 2 commits into
masterfrom
jtr/fix-sse-personal-settings
Jul 29, 2026
Merged

fix(encryption): bind personal private key password inputs#62027
susnux merged 2 commits into
masterfrom
jtr/fix-sse-personal-settings

Conversation

@joshtrichards

@joshtrichards joshtrichards commented Jul 11, 2026

Copy link
Copy Markdown
Member

Summary

Bind the password inputs in SettingsPersonalChangePrivateKey.vue to the refs used by onSubmit().

Changes

  • add v-model binding for the old log-in password field
  • add v-model binding for the current log-in password field
  • mark both fields as required

TODO

  • Backport to whenever Vue implemented was changed (TBD but at least v34; possibly v33 too)
  • A follow-up PR should get implemented with frontend testing for SSE

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@joshtrichards

joshtrichards commented Jul 11, 2026

Copy link
Copy Markdown
Member Author

/compile

@joshtrichards joshtrichards added this to the Nextcloud 35 milestone Jul 11, 2026
@joshtrichards
joshtrichards requested a review from susnux July 11, 2026 19:01
@joshtrichards joshtrichards added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 11, 2026
@joshtrichards

joshtrichards commented Jul 11, 2026

Copy link
Copy Markdown
Member Author

/backport to stable34

@joshtrichards

joshtrichards commented Jul 11, 2026

Copy link
Copy Markdown
Member Author

/backport to stable33

@joshtrichards
joshtrichards marked this pull request as ready for review July 11, 2026 19:02
@joshtrichards
joshtrichards requested a review from a team as a code owner July 11, 2026 19:02
@joshtrichards
joshtrichards requested review from nfebe and sorbaugh and removed request for a team July 11, 2026 19:02
@joshtrichards joshtrichards mentioned this pull request Jul 11, 2026
Closed
8 tasks
@susnux susnux added the community pull requests from community label Jul 14, 2026
@joshtrichards joshtrichards mentioned this pull request Jul 28, 2026
Closed
8 tasks
@susnux

susnux commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

/compile rebase

@susnux
susnux requested review from kristian-zendato, leftybournes and salmart-dev and removed request for nfebe and sorbaugh July 29, 2026 14:15
@joshtrichards @nextcloud-command
fix(encryption): bind private key password fields in personal settings
9b72de9 
Fixes #61955 

Signed-off-by: Josh <josh.t.richards@gmail.com>
@nextcloud-command
chore(assets): Recompile assets
fddc188 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command
nextcloud-command force-pushed the jtr/fix-sse-personal-settings branch from fcc58f6 to fddc188 Compare July 29, 2026 14:21
@susnux
susnux merged commit 3541356 into master Jul 29, 2026
132 checks passed
@susnux
susnux deleted the jtr/fix-sse-personal-settings branch July 29, 2026 14:49
This was referenced Jul 29, 2026
Draft
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes
@CarlSchwan CarlSchwan CarlSchwan approved these changes
@salmart-dev salmart-dev Awaiting requested review from salmart-dev
@leftybournes leftybournes Awaiting requested review from leftybournes
@kristian-zendato kristian-zendato Awaiting requested review from kristian-zendato

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug community pull requests from community feature: encryption (server-side) regression

Projects

None yet

Milestone

Nextcloud 35

Development

Successfully merging this pull request may close these issues.

[Bug]: Errors when changing login password in a server with SSE user encryption

4 participants

@joshtrichards @susnux @CarlSchwan @nextcloud-command