fix(preview): Handle unique constraints violation exception - #61950
Merged
Conversation
CarlSchwan
requested review from
Altahrim and
salmart-dev
and removed request for
a team
July 9, 2026 15:24
Member
Author
|
/backport to stable34 |
susnux
approved these changes
Jul 9, 2026
come-nc
approved these changes
Jul 9, 2026
Member
|
I don't think the recovery path works as written, worth review in case I'm missing a key info here.
So the exact race this PR targets would still crash, just with a different exception than before. |
CarlSchwan
force-pushed
the
carl/catch-unique-exception
branch
from
July 10, 2026 08:24
b373378 to
8785794
Compare
Delete the preview from storage and fetch the actual one from the DB. This should not happen often. Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/catch-unique-exception
branch
from
July 14, 2026 11:01
8785794 to
7629df9
Compare
Contributor
|
Hey @CarlSchwan still seeing this on NC 34.0.2 do need to open a new request? or will it be on NC34.0.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Delete the preview from storage and fetch the actual one from the DB. This should not happen often.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)