Refactor: Centralize logic for checking if a share is password protected - #61946
Conversation
|
@miaulalala This is the refactoring portion we were talking about. |
f019b17 to
85cac33
Compare
85cac33 to
16711c3
Compare
|
@come-nc Thanks for the review! I just force-pushed due to the missing signature. |
16711c3 to
cd69517
Compare
Head branch was pushed to by a user without write access
cd69517 to
11ea799
Compare
|
@CarlSchwan @come-nc I just pushed a few fixes for mocked shares in various unit tests (which caused issues I missed before the CI pipelines were run). |
11ea799 to
10dd884
Compare
5dff957 to
f0c1b56
Compare
…rd protected in IShare->isPasswordProtected() Signed-off-by: Tobias Knöppler <tobias@knoeppler.org>
f0c1b56 to
b554ab9
Compare
|
@come-nc See this comment on the downstream PR #61722 regarding the failing CI jobs. Let me know, if anything from my side is required (e.g. rebasing) :) |
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
Previously, there were numerous checks that check whether a share has an empty or null password scattered around the code base. This PR moves the logic for this into a single, central method on IShare.
This PR prepares and is a prerequisite for #61722.
Checklist
3. to review, feature component)stable32)AI (if applicable)