Skip to content

fix(settings): missing end of html tag - #61880

Open
Quentin-Guillemin wants to merge 1 commit into
nextcloud:masterfrom
Quentin-Guillemin:fix/settings/end-of-html-tag
Open

fix(settings): missing end of html tag#61880
Quentin-Guillemin wants to merge 1 commit into
nextcloud:masterfrom
Quentin-Guillemin:fix/settings/end-of-html-tag

Conversation

@Quentin-Guillemin

@Quentin-Guillemin Quentin-Guillemin commented Jul 7, 2026

Copy link
Copy Markdown

Add missing end of ul and <div class="help-content__body">.

@Quentin-Guillemin
Quentin-Guillemin requested a review from a team as a code owner July 7, 2026 15:09
@Quentin-Guillemin
Quentin-Guillemin requested review from Altahrim, ArtificialOwl, leftybournes and provokateurin and removed request for a team July 7, 2026 15:09
@provokateurin

provokateurin commented Jul 8, 2026

Copy link
Copy Markdown
Member

Hey, please target the master branch with this PR. Please also remove the unrelated formatting changes.

@provokateurin
provokateurin marked this pull request as draft July 8, 2026 05:56
@Quentin-Guillemin
Quentin-Guillemin force-pushed the fix/settings/end-of-html-tag branch from 3bc8264 to 517712a Compare July 8, 2026 07:58
@provokateurin
provokateurin changed the base branch from stable33 to master July 8, 2026 07:58
provokateurin
provokateurin approved these changes Jul 8, 2026
View reviewed changes

@provokateurin provokateurin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@provokateurin
provokateurin marked this pull request as ready for review July 8, 2026 08:00
@provokateurin provokateurin added this to the Nextcloud 35 milestone Jul 8, 2026
@provokateurin provokateurin added bug 3. to review Waiting for reviews labels Jul 8, 2026
@provokateurin

provokateurin commented Jul 8, 2026

Copy link
Copy Markdown
Member

/backport to stable34 please

@provokateurin

provokateurin commented Jul 8, 2026

Copy link
Copy Markdown
Member

/backport to stable33 please

@provokateurin

provokateurin commented Jul 8, 2026

Copy link
Copy Markdown
Member

/backport to stable32 please

@provokateurin
provokateurin enabled auto-merge July 8, 2026 08:01
@provokateurin

provokateurin commented Jul 8, 2026

Copy link
Copy Markdown
Member

@Quentin-Guillemin please sign the DCO by using git commit --amend --signoff

@Quentin-Guillemin
fix(settings): missing end of html tag
0e94662 
Signed-off-by: Quentin Guillemin <quentin.guillemin@recia.fr>
auto-merge was automatically disabled July 8, 2026 08:14

Head branch was pushed to by a user without write access

@Quentin-Guillemin
Quentin-Guillemin force-pushed the fix/settings/end-of-html-tag branch from 517712a to 0e94662 Compare July 8, 2026 08:14
@susnux susnux added the community pull requests from community label Jul 14, 2026
@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pringelmann pringelmann pringelmann approved these changes
@skjnldsv skjnldsv skjnldsv approved these changes
@provokateurin provokateurin provokateurin approved these changes
@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend
@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews backport-request bug community pull requests from community feedback-requested

Projects

None yet

Milestone

Nextcloud 35

Development

Successfully merging this pull request may close these issues.

5 participants

@Quentin-Guillemin @provokateurin @pringelmann @skjnldsv @susnux