[frontend] Support one-time passwords (e.g. for public file shares) - #61733
[frontend] Support one-time passwords (e.g. for public file shares)#61733theCalcaholic wants to merge 8 commits into
Conversation
714abb7 to
596baac
Compare
4314d3c to
6d728a3
Compare
|
The frontend part is now also complete and ready for review. Let me know if there's any way I can support :) |
6edc402 to
70a12ed
Compare
…sword protected in IShare->isPasswordProtected()
…ge (if available)
70a12ed to
11445e7
Compare
|
After talking with @miaulalala I am closing this PR and merging it into the prerequisite (formerly backend) PR. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
This PR contains the frontend changes and is based on the corresponding backend PR, which can be found at #61722. This PR needs to be merged after the backend PR.
Work in-progress
This PR is functional but still in progress. I would very much appreciate architecture and implementation specific feedback while I'm working on polishing and the missing UI portion for OTP protected share creation.
Summary
This PR adds one-time password management to Nextcloud server and integrates them with the files_sharing app.
Screenshots
Password authentication page for OTP protected shares
Example OTP email sent to users
The logo is not displayed, because I'm testing with a local Nextcloud instance at a non-public URL.
New UI for selecting an authentication method during share creation
Previous UI for selecting an auth method for comparison
TODO
Changes made
The authentication page for public shares has been updated to accomodate OTPs (see screenshot).
When an OTP is required for a share, the authentication form will change to present a button for requesting an OTP in addition to the normal password field. It will also display a different title above the password field.
The email template for sending OTPs to users is located in
apps/otp_provider_email/lib/listener/SendOneTimePasswordEventListener.phpand uses Nextclouds usual APIs for templating emails.Another change will happen in the sharing sidebar (files->sidebar->sharing). The work on this is still ongoing.
Checklist
3. to review, feature component)stable32)AI (if applicable)