Skip to content

refactor(Node): Use new properties declaration in constructor #61687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CarlSchwan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor(Node): Use new properties declaration in constructor #61687

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions lib/private/Files/Node/Node.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,21 +29,12 @@
// FIXME: this class really should be abstract (+1)
class Node implements INode {
/**
* @var View $view
*/
protected $view;

protected IRootFolder $root;

/**
* @param View $view
* @param \OCP\Files\IRootFolder $root
* @param string $path
* @param FileInfo $fileInfo
*/
public function __construct(
IRootFolder $root,
$view,
protected IRootFolder $root,
protected View $view,
protected $path,
Comment thread
cristianscheid marked this conversation as resolved.
protected ?FileInfo $fileInfo = null,
protected ?INode $parent = null,
Expand All @@ -52,8 +43,6 @@ public function __construct(
if (Filesystem::normalizePath($view->getRoot()) !== '/') {
throw new PreConditionNotMetException('The view passed to the node should not have any fake root set');
}
$this->view = $view;
$this->root = $root;
}

/**
Expand Down
Loading