Skip to content

feat(bruteforce): improve bruteforce protection command output - #61682

Merged
nickvergessen merged 2 commits into
masterfrom
feat/improve-bruteforce-protection-command-output
Jul 7, 2026
Merged

feat(bruteforce): improve bruteforce protection command output#61682
nickvergessen merged 2 commits into
masterfrom
feat/improve-bruteforce-protection-command-output

Conversation

@kyteinsky

@kyteinsky kyteinsky commented Jun 30, 2026

Copy link
Copy Markdown
Contributor
  • Resolves: #

Summary

  • Add hint on the delay output that it's in milliseconds
  • Add "interval" option to the command

TODO

  • It feels like the command might be used in a script. Should the key change be avoided and done differently? Or perhaps documented as a breaking change? ... Does not need to be explicit in the first place?

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@kyteinsky
kyteinsky requested a review from a team as a code owner June 30, 2026 21:08
@kyteinsky
kyteinsky requested review from Altahrim, come-nc, leftybournes and provokateurin and removed request for a team June 30, 2026 21:09
@kyteinsky kyteinsky changed the title Feat/improve bruteforce protection command output feat(bruteforce): improve bruteforce protection command output Jun 30, 2026
@kyteinsky kyteinsky added enhancement help wanted security papercut Annoying recurring UX issue with possibly simple fix. php Pull requests that update Php code Nice to have labels Jun 30, 2026
Comment thread core/Command/Security/BruteforceAttempts.php Outdated
kyteinsky added 2 commits July 1, 2026 13:45
Signed-off-by: kyteinsky <kyteinsky@gmail.com>
Signed-off-by: kyteinsky <kyteinsky@gmail.com>
@kyteinsky
kyteinsky force-pushed the feat/improve-bruteforce-protection-command-output branch from 9966f51 to 738f237 Compare July 1, 2026 08:16
@artonge artonge added the 3. to review Waiting for reviews label Jul 2, 2026
@kyteinsky

Copy link
Copy Markdown
Contributor Author

failure seems unrelated, and doesn't pass in a re-run.
force merge?

@nickvergessen
nickvergessen merged commit efe0f83 into master Jul 7, 2026
213 of 227 checks passed
@nickvergessen
nickvergessen deleted the feat/improve-bruteforce-protection-command-output branch July 7, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement help wanted Nice to have papercut Annoying recurring UX issue with possibly simple fix. php Pull requests that update Php code security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants