fix(core): reduce header height - #61628
Merged
Merged
Conversation
susnux
requested review from
nfebe,
skjnldsv and
sorbaugh
and removed request for
a team
June 27, 2026 14:32
susnux
requested review from
come-nc,
kra-mo and
provokateurin
and removed request for
a team
June 27, 2026 14:32
kra-mo
requested changes
Jun 29, 2026
Member
|
Also, this seems to unalign the app menu, which I guess was manually aligned @pringelmann? 
|
kra-mo
approved these changes
Jun 29, 2026
CarlSchwan
approved these changes
Jun 29, 2026
The header height is reduced to the newer clickable area / button sizes: One interactive element has a height of 34px so the header is reduced to 42px height: - 1x grid-baseline (4px) - 1x clickable area (34px) - 1x grid-baseline (4px) Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Contributor
Author
Adjusted that in the recent commit :) |
susnux
force-pushed
the
refactor/header-height
branch
from
June 29, 2026 14:18
73d8b46 to
b1f5e0a
Compare
susnux
commented
Jun 29, 2026
42px looks ever so slightly too small and the search bar can get caught up in browser hinting shenanigans which will make the padding look uneven. 44 is a bit nicer. Co-authored-by: Laura Kramolis <git@kramo.page> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
refactor/header-height
branch
from
June 29, 2026 14:20
33e170e to
96ca0a2
Compare
come-nc
removed their request for review
June 29, 2026 15:33
Contributor
|
Will take a look at the alignment issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The header height is reduced to the newer clickable area / button sizes: One interactive element has a height of 34px so the header is reduced to 42px height:
Checklist
3. to review, feature component)stable32)AI (if applicable)