Skip to content

refactor: Remove most usages of IAppContainer and IServerContainer - #60780

Merged
AndyScherzinger merged 2 commits into
masterfrom
carl/modernize-containers
Jul 16, 2026
Merged

refactor: Remove most usages of IAppContainer and IServerContainer#60780
AndyScherzinger merged 2 commits into
masterfrom
carl/modernize-containers

Conversation

@CarlSchwan

@CarlSchwan CarlSchwan commented May 27, 2026

Copy link
Copy Markdown
Member
  • Resolves: #

Summary

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@CarlSchwan
CarlSchwan force-pushed the carl/modernize-containers branch 4 times, most recently from aed4795 to 7d2081f Compare May 28, 2026 10:10
@CarlSchwan
CarlSchwan marked this pull request as ready for review May 28, 2026 10:14
@CarlSchwan
CarlSchwan requested review from ArtificialOwl, come-nc, leftybournes and salmart-dev and removed request for a team May 28, 2026 10:14
provokateurin
provokateurin requested changes May 28, 2026
View reviewed changes

@provokateurin provokateurin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay you got me :D

Comment thread lib/private/AppFramework/Bootstrap/RegistrationContext.php Outdated
Comment thread lib/private/AppFramework/Bootstrap/RegistrationContext.php Outdated
Comment thread lib/private/AppFramework/Bootstrap/RegistrationContext.php Outdated
Comment thread lib/private/AppFramework/Bootstrap/RegistrationContext.php Outdated
Comment thread lib/private/User/Session.php Outdated
Comment thread tests/lib/Log/LogFactoryTest.php Outdated
@CarlSchwan
CarlSchwan force-pushed the carl/modernize-containers branch 5 times, most recently from d685b87 to 2cb0c38 Compare May 29, 2026 08:40
come-nc
come-nc reviewed Jun 1, 2026
View reviewed changes
Comment thread lib/public/AppFramework/App.php Outdated
@CarlSchwan
CarlSchwan force-pushed the carl/modernize-containers branch from 2cb0c38 to 1839e8a Compare June 1, 2026 09:59
@CarlSchwan
CarlSchwan requested a review from provokateurin June 1, 2026 10:00
@come-nc

come-nc commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Related

There was 1 error:

1) lib\AppFramework\Bootstrap\RegistrationContextTest::testRegisterServiceAlias
PHPUnit\Framework\MockObject\MethodCannotBeConfiguredException: Trying to configure method "registerAlias" which cannot be configured because it does not exist, has not been specified, is final, or is static

/home/runner/actions-runner/_work/server/server/tests/lib/AppFramework/Bootstrap/RegistrationContextTest.php:100

@CarlSchwan CarlSchwan mentioned this pull request Jun 2, 2026
Closed
8 tasks
@CarlSchwan
CarlSchwan force-pushed the carl/modernize-containers branch from 1839e8a to f46295b Compare June 2, 2026 08:08
@susnux susnux added this to the Nextcloud 35 milestone Jun 9, 2026
@joshtrichards joshtrichards added the technical debt 🧱 🤔🚀 label Jul 3, 2026
@CarlSchwan
CarlSchwan force-pushed the carl/modernize-containers branch 2 times, most recently from 61a5a07 to dc5a7fd Compare July 14, 2026 11:02
@CarlSchwan
refactor: Remove most usages of IAppContainer and IServerContainer
1d55835 
And port more stuff to standard ContainerInterface interface

Signed-off-by: Carl Schwan <carlschwan@kde.org>
@CarlSchwan
fix(ISession): Fix typo in api doc
326e3d6 
Signed-off-by: Carl Schwan <carlschwan@kde.org>
@CarlSchwan
CarlSchwan force-pushed the carl/modernize-containers branch from dc5a7fd to 326e3d6 Compare July 16, 2026 06:00
@CarlSchwan CarlSchwan added 3. to review Waiting for reviews 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 16, 2026
@AndyScherzinger
AndyScherzinger merged commit 7c8c035 into master Jul 16, 2026
230 of 248 checks passed
@AndyScherzinger
AndyScherzinger deleted the carl/modernize-containers branch July 16, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miaulalala miaulalala miaulalala approved these changes
@provokateurin provokateurin provokateurin approved these changes
@come-nc come-nc come-nc approved these changes
@nickvergessen nickvergessen Awaiting requested review from nickvergessen nickvergessen is a code owner
@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst ChristophWurst is a code owner
@SebastianKrupinski SebastianKrupinski Awaiting requested review from SebastianKrupinski SebastianKrupinski is a code owner
@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld is a code owner
@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@salmart-dev salmart-dev Awaiting requested review from salmart-dev salmart-dev is a code owner automatically assigned from nextcloud/server-backend
@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish technical debt 🧱 🤔🚀

Projects

None yet

Milestone

Nextcloud 35

Development

Successfully merging this pull request may close these issues.

7 participants

@CarlSchwan @come-nc @miaulalala @provokateurin @AndyScherzinger @joshtrichards @susnux