Skip to content

Move invite-accepted capability and implementation to contacts app. - #57853

Merged
miaulalala merged 1 commit into
nextcloud:masterfrom
redblom:move-ocm-invite-accepted-route-impl-to-contacts-app
Jul 14, 2026
Merged

Move invite-accepted capability and implementation to contacts app.#57853
miaulalala merged 1 commit into
nextcloud:masterfrom
redblom:move-ocm-invite-accepted-route-impl-to-contacts-app

Conversation

@redblom

@redblom redblom commented Jan 27, 2026

Copy link
Copy Markdown
Contributor
  • Resolves: #

Summary

Code moved to contacts app, see nextcloud/contacts#4417

TODO

  • deal with inviteAcceptedDialog code

Checklist

@redblom
redblom requested a review from a team as a code owner January 27, 2026 15:43
@redblom
redblom requested review from leftybournes, nfebe, salmart-dev and sorbaugh and removed request for a team January 27, 2026 15:43
@redblom
redblom marked this pull request as draft January 27, 2026 15:43
@ChristophWurst

Copy link
Copy Markdown
Member

@redblom why is this moved out of server and could it break OCM when the contacts app is not installed? the app is not shipped. it is optional.

@redblom
redblom force-pushed the move-ocm-invite-accepted-route-impl-to-contacts-app branch from 7cb53f3 to 2d2e4a1 Compare January 28, 2026 16:58
@ArtificialOwl

Copy link
Copy Markdown
Member

@redblom why is this moved out of server and could it break OCM when the contacts app is not installed? the app is not shipped. it is optional.

This is done on my request:

  • it is moved out of server because the implementation of the feature creates its own db table and does not provide an API to manage it,
  • it will not break OCM, it will only not enable the 'invite-accepted' capability if contacts is not installed. the capability is useless without the contacts app,
  • contacts will register the capability and fully manage the db table

@ArtificialOwl

Copy link
Copy Markdown
Member

let's ping @mickenordin on this one !

@mickenordin
mickenordin force-pushed the move-ocm-invite-accepted-route-impl-to-contacts-app branch from 2d2e4a1 to aea3c70 Compare January 28, 2026 18:22
@mickenordin

Copy link
Copy Markdown
Contributor

let's ping @mickenordin on this one !

I haven't reviewed the change, but in principal I see no problem with it.

@redblom
redblom force-pushed the move-ocm-invite-accepted-route-impl-to-contacts-app branch from aea3c70 to 254681c Compare January 30, 2026 09:26
@redblom

redblom commented Jan 30, 2026

Copy link
Copy Markdown
Contributor Author

Rebased, squashed, removed draft label.

@redblom
redblom marked this pull request as ready for review January 30, 2026 10:12
@redblom
redblom requested review from a team and nickvergessen as code owners January 30, 2026 10:12
Comment thread lib/public/OCM/Events/LocalOCMDiscoveryEvent.php Outdated
@redblom
redblom force-pushed the move-ocm-invite-accepted-route-impl-to-contacts-app branch 2 times, most recently from 3948b49 to 57769de Compare February 4, 2026 09:30
@redblom
redblom requested a review from nickvergessen February 4, 2026 09:33
@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@miaulalala

This comment was marked as resolved.

@redblom
redblom force-pushed the move-ocm-invite-accepted-route-impl-to-contacts-app branch 2 times, most recently from 7f0ecf2 to ddfe68d Compare February 17, 2026 10:36
@redblom

This comment was marked as resolved.

@redblom
redblom force-pushed the move-ocm-invite-accepted-route-impl-to-contacts-app branch from 9dfb752 to 43701a5 Compare June 19, 2026 15:57
@redblom

redblom commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

Rebased from master.

@redblom redblom reopened this Jun 19, 2026
@redblom
redblom force-pushed the move-ocm-invite-accepted-route-impl-to-contacts-app branch 3 times, most recently from f532694 to b94189b Compare June 23, 2026 13:47

@miaulalala miaulalala left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, all changes implemented

@miaulalala

Copy link
Copy Markdown
Contributor

@ArtificialOwl your review would be apprechiated

@DerDreschner
DerDreschner self-requested a review July 8, 2026 14:44
Comment thread lib/public/OCM/Events/LocalOCMDiscoveryEvent.php Outdated
@redblom
redblom requested a review from cristianscheid July 13, 2026 01:03
@miaulalala

Copy link
Copy Markdown
Contributor

@redblom can you sqash you commits please?

…cts app.

Signed-off-by: Antoon P. <antoon.prins@surf.nl>
@redblom
redblom force-pushed the move-ocm-invite-accepted-route-impl-to-contacts-app branch from f51cbc0 to 5cbdfac Compare July 13, 2026 18:23
@miaulalala
miaulalala merged commit ccaa4c5 into nextcloud:master Jul 14, 2026
206 of 208 checks passed
@welcome

welcome Bot commented Jul 14, 2026

Copy link
Copy Markdown

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@backportbot

backportbot Bot commented Jul 14, 2026

Copy link
Copy Markdown

The backport to stable33 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable33
git pull origin stable33

# Create the new backport branch
git checkout -b backport/57853/stable33

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 5cbdfac0

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/57853/stable33

Error: Failed to check for changes with origin/stable33: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@miaulalala

Copy link
Copy Markdown
Contributor

Congrats @redblom! Christoph left a comment on the contacts PR - that will need to be addressed, then we're done 🥳

@miaulalala

Copy link
Copy Markdown
Contributor

/backport to stable34

@miaulalala

Copy link
Copy Markdown
Contributor

/backport to stable33

@backportbot

backportbot Bot commented Jul 22, 2026

Copy link
Copy Markdown

The backport to stable34 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable34
git pull origin stable34

# Create the new backport branch
git checkout -b backport/57853/stable34

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 5cbdfac0

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/57853/stable34

Error: Failed to check for changes with origin/stable34: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot

backportbot Bot commented Jul 22, 2026

Copy link
Copy Markdown

The backport to stable33 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable33
git pull origin stable33

# Create the new backport branch
git checkout -b backport/57853/stable33

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 5cbdfac0

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/57853/stable33

Error: Failed to check for changes with origin/stable33: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

redblom added a commit to redblom/nextcloud-server that referenced this pull request Jul 24, 2026
…cts app.

Backport PR nextcloud#57853

Signed-off-by: Antoon P. <antoon.prins@surf.nl>
redblom added a commit to redblom/nextcloud-server that referenced this pull request Jul 25, 2026
…cts app.

Backport of PR nextcloud#57853

Signed-off-by: Antoon P. <antoon.prins@surf.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews backport-request community pull requests from community feature: federation feedback-requested pending documentation This pull request needs an associated documentation update

Projects

None yet

Development

Successfully merging this pull request may close these issues.