Move invite-accepted capability and implementation to contacts app. - #57853
Conversation
|
@redblom why is this moved out of server and could it break OCM when the contacts app is not installed? the app is not shipped. it is optional. |
7cb53f3 to
2d2e4a1
Compare
This is done on my request:
|
|
let's ping @mickenordin on this one ! |
2d2e4a1 to
aea3c70
Compare
I haven't reviewed the change, but in principal I see no problem with it. |
aea3c70 to
254681c
Compare
|
Rebased, squashed, removed |
3948b49 to
57769de
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
This comment was marked as resolved.
This comment was marked as resolved.
7f0ecf2 to
ddfe68d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
9dfb752 to
43701a5
Compare
|
Rebased from master. |
f532694 to
b94189b
Compare
miaulalala
left a comment
There was a problem hiding this comment.
LGTM, all changes implemented
|
@ArtificialOwl your review would be apprechiated |
|
@redblom can you sqash you commits please? |
…cts app. Signed-off-by: Antoon P. <antoon.prins@surf.nl>
f51cbc0 to
5cbdfac
Compare
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
The backport to # Switch to the target branch and update it
git checkout stable33
git pull origin stable33
# Create the new backport branch
git checkout -b backport/57853/stable33
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 5cbdfac0
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/57853/stable33Error: Failed to check for changes with origin/stable33: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
Congrats @redblom! Christoph left a comment on the contacts PR - that will need to be addressed, then we're done 🥳 |
|
/backport to stable34 |
|
/backport to stable33 |
|
The backport to # Switch to the target branch and update it
git checkout stable34
git pull origin stable34
# Create the new backport branch
git checkout -b backport/57853/stable34
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 5cbdfac0
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/57853/stable34Error: Failed to check for changes with origin/stable34: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout stable33
git pull origin stable33
# Create the new backport branch
git checkout -b backport/57853/stable33
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 5cbdfac0
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/57853/stable33Error: Failed to check for changes with origin/stable33: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
…cts app. Backport PR nextcloud#57853 Signed-off-by: Antoon P. <antoon.prins@surf.nl>
…cts app. Backport of PR nextcloud#57853 Signed-off-by: Antoon P. <antoon.prins@surf.nl>
Summary
Code moved to contacts app, see nextcloud/contacts#4417
TODO
Checklist
3. to review, feature component)stable32)