fix(mailbox): Flag shared mailboxes as shared - #13378
Open
kesselb wants to merge 1 commit into
Open
Conversation
kesselb
requested review from
SebastianKrupinski,
Copilot and
hamza221
and removed request for
ChristophWurst
July 28, 2026 22:09
There was a problem hiding this comment.
Pull request overview
This PR updates IMAP namespace handling in OCA\Mail\IMAP\MailboxSync so that mailboxes in the RFC-2342 “Shared Namespace” (namespace type 3) are flagged as shared, in addition to the existing “Other Users’ Namespace” (type 2).
Changes:
- Expand the “shared mailbox” detection to include
NS_SHAREDnamespaces. - Centralize the non-personal namespace types into a class constant used by the shared-detection logic.
RFC-2342 IMAP4 Namespace [^1] 1 Personal Namespace 2 Other Users' Namespace 3 Shared Namespace Before this change only mailboxes with type 2 (Other User's Namespace) were flagged as shared. Now also mailboxes with type 3 (Shared Namespace) are flagged. [^1]: https://datatracker.ietf.org/doc/html/rfc2342 Assisted-by: Claude:claude-opus-5 Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
shared-mailbox-detection
branch
from
July 28, 2026 22:14
21c696d to
2c71bdc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For ChristophWurst/docker-imap-devel#21
RFC-2342 IMAP4 Namespace 1
1 Personal Namespace
2 Other Users' Namespace
3 Shared Namespace
Before this change only mailboxes with type 2 (Other User's Namespace) were flagged as shared.
Now also mailboxes with type 3 (Shared Namespace) are flagged.
🤖 AI (if applicable)
Footnotes
https://datatracker.ietf.org/doc/html/rfc2342 ↩