fix: disabling shortcut for links when not editing html - #13364
Open
madbob wants to merge 1 commit into
Open
Conversation
Signed-off-by: Roberto Guido <info@madbob.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even when formatting options of
TextEditorare disabled, the keyboard shortcut to add links (Ctrl+K) is enabled. But, for some reason I've not entirely understood, the floating modal to insert the link is totally unusable and cannot be edited.This PR disables the "link" command and, consequently, the opening of the sub-modal. The user who wants to add a link have to explicitely enable rich formatting (or "accidentally" enable it, for example using a mention, which is unaffected by this change).
Fixes #7641
Please note that this do not explicitely targets similar issue related to the sometimes breaking link sub-modal, as #9605 and #10977.