feat: filtering folders in mailbox picker - #13357
Open
madbob wants to merge 1 commit into
Open
Conversation
Signed-off-by: Roberto Guido <info@madbob.org>
Collaborator
Author
|
Note to myself: the "disposable localStore" will be useful also for #616 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General review of the
MailboxPickercomponent, including:NcBreadcrumbs#11158 is not entirely fixed as it is still missing a "Recent selected folders" option, which in my opinion can be interesting and for which I require some feedback.
Introducing a new server-kept preference seems to be an overkill, a disposable client-side array where to save the (latest 5?) selected folders would be recommended. But I've not been able to find something like a "client-side only store", some place where to keep informations just for the current session. A new
src/store/localStore.js, where to keep some arrays, may be an acceptable solution?Edit: fixes #7536 (similar to #11158, not including the Recent/Favorites part).