feat: text blocks empty state - #13356
Open
madbob wants to merge 1 commit into
Open
Conversation
Signed-off-by: Roberto Guido <info@madbob.org>
madbob
force-pushed
the
fixing_textblocks_1
branch
from
July 25, 2026 13:30
c12bff2 to
72edb79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When no Text Blocks are defined, the picker modal accesible from Composer is a bit confusing as requires to choose something that do not exists.
This PR includes a basic message, aimed to increase discoverability of the Text Blocks feature.
Plus: I've moved the buttons of
TextBlockModalto be handled as nativeNcDialogbuttons. I must confess it is not entirely clear to me if there is some policy about this functionality ofNcDialog: sometime buttons are managed with dialog's proper property, sometime those are just hard-coded into the modal's body (often with custom CSS style to force alignment). In my opinion usage of nativebuttonsproperty improves themeability, but guidance and suggestions are appreciated.