fix: actions menu for envelope - #13296
Conversation
|
Thanks! Will try to review soon 🤞 |
|
I've overwritten the previous commit, following the wise notices of @ChristophWurst Highlights:
|
Signed-off-by: Roberto Guido <info@madbob.org>
|
I've realized that After this PR is merged, a more comprehensive review would be required. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
I've simplified a bit the management of actions menu in
EnvelopeSkeleton, to handle the many involved conditions.Notes:
setTimeoutinhandleActionsUpdateOpenis to delay a bit the status change for the closed menu; without it, the flickering menu mentioned in Action menu flickers for some actions #12586 cannot be really fixed. I've already opened an issue for nextcloud-vue in order to have a proper way to manage thisMessageHTMLBody. The (untracked) issue is thatNcActionsregisters a global handler to intercept clicks made on wholedocumentand determines if the opened menu has to be closed, but clicks occurring over the iframe ofMessageHTMLBodyare "absorbed" by the iframe itself and do not bubble to the rest of the document. This change is intended to pre-intercept those clicks and properly deliver them to that global callback: now action menus are closed also when clicking on the HTML body of an email (which often occupies the large portion of the screen). If those changes seem too unrelated to the scope of this PR, I can split them in a different dedicated PREnvelopeSkeletonI've found a few props that are never set by anyone and I guess can be removed.forceDisplayActionshas been here suppressed, whilecounterNumberandcounterTypeare still there. The commit introducing them (0b15b42) provides no hints about their scope. If no-one has any suggestion about their meaning and intended usage, I can remove them within this same PRFixes #12586