feat(ui): promote archive to an envelope primary action - #13295
Conversation
|
Thanks for opening your first pull request in this repository! ✌️ |
|
Thank you for the contribution @nimishavijay fine by you? @mrx8086 please describe the changes in your words next time and don't use AI for the PR description: https://github.com/nextcloud/.github/blob/master/CONTRIBUTING.md#ai-assisted-contributions |
Favorite, read and important are available as one-click primary actions on the envelope menu, but archiving - a core step of inbox-zero style workflows - is buried further down the list. Promote the existing archive entry to a fourth primary action button so it is reachable with a single click, reusing the existing onArchive() handler, showArchiveButton/disableArchiveButton logic and ACL checks. The button only shows when an archive mailbox is configured and the account has the required ACLs, mirroring the previous menu entry. No new translatable strings are introduced. Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: Mathias Riechsteiner <mathias@riechsteiner.online>
e4f8583 to
d9092b5
Compare
|
Thank you, and sorry about that — I'll write the descriptions and replies personally going forward. The commit trailer is updated to the current |
|
Fine by me, but keep in mind #13310 which adds reply also. Reply should be the first option and then archive. |
|
Thanks for the feedback, I agree. I'll wait until the reply PR (#13310) is merged, then I'll rebase and put the archive button after reply. Thanks! |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
Favorite, read and important are available as one-click primary action
buttons at the top of the envelope actions menu, but archiving — a core
step of inbox-zero style workflows — sits further down the entry list.
This PR promotes the existing archive entry to a fourth primary action
button:
onArchive()handler,showArchiveButton/disableArchiveButtoncomputed properties and thehasArchiveAclcheck — no behavioral changes.
account and the ACLs allow it, exactly like the previous menu entry.
the same action does not appear twice in one open menu.
"Archive message" strings are reused.
If the design team prefers to keep the primary row at three buttons, I
am happy to adjust (e.g. make the fourth button conditional or move it
behind a setting) — feedback welcome.
Screenshots
Screenshots of the envelope actions menu before/after will follow.
Checklist
npx eslint src/components/Envelope.vue— no new warnings)npm run build)AI-assistedtrailer are added