test(php): add phpunit tests for OauthService by saw-jan · Pull Request #1131 · nextcloud/integration_openproject

saw-jan · 2026-07-29T10:06:50Z

Description

Add phpunit tests for OauthService class

Related Issue or Workpackage

Resolves: https://community.openproject.org/wp/NEX-106

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Tests only (no source changes)

Checklist:

Code changes
Unit tests added
Acceptance tests added
Updated CHANGELOG.md file

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

github-actions · 2026-07-31T04:13:45Z

PHP Code Coverage

Coverage after merging test/phpunit-oauth-service into master will be

69.23%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
integration_openproject/server/apps/integration_openproject/lib
Capabilities.php	0%	100%	0%	0%	24, 31–40
OIDCClientMapper.php	0%	100%	0%	0%	29, 40–49, 52
ServerVersion.php	0%	100%	0%	0%	17, 27–29, 32, 41–42
TokenEventFactory.php	100%	100%	100%	100%
integration_openproject/server/apps/integration_openproject/lib/AppInfo
Application.php	37.04%	100%	50%	36%	116–118, 121–135, 138, 140, 142–143, 146, 151–152, 156–159, 161–172, 174, 177, 181, 185–187, 220
integration_openproject/server/apps/integration_openproject/lib/BackgroundJob
RemoveExpiredDirectUploadTokens.php	0%	100%	0%	0%	28, 30–32, 41–42
integration_openproject/server/apps/integration_openproject/lib/Controller
ConfigController.php	79.16%	100%	70.59%	79.51%	114, 151–152, 154, 156–158, 160–163, 166–167, 169, 194, 198–200, 442–444, 446–448, 497, 577–581, 592, 606–609, 617, 621–624, 663, 669–684, 725, 728, 731–746, 760–763, 765–769
DirectDownloadController.php	0%	100%	0%	0%	33–35, 50–52, 54–61
DirectUploadController.php	71.03%	100%	100%	70.21%	117–119, 162–164, 175, 179–182, 184, 194, 201, 217–219, 221–222, 225–230, 233, 235, 245–247, 253–255, 263–265, 280–282, 301, 306, 312
FilesController.php	85.60%	100%	83.33%	85.71%	181–182, 244, 253, 270–273, 278–280, 285–287, 299, 301, 304
OpenProjectAPIController.php	81.09%	100%	82.35%	80.98%	116, 155, 202–204, 207–214, 216–220, 222, 241, 266, 331, 381, 401, 448, 473–475, 478–482, 484, 66
OpenProjectController.php	96.45%	100%	80%	96.95%	241–245
integration_openproject/server/apps/integration_openproject/lib/Dashboard
OpenProjectWidget.php	0%	100%	0%	0%	101, 108–109, 111–116, 118–122, 124–126, 129–140, 61–66, 73, 80, 87, 94
integration_openproject/server/apps/integration_openproject/lib/Exception
OpenprojectAvatarErrorException.php	100%	100%	100%	100%
OpenprojectErrorException.php	100%	100%	100%	100%
OpenprojectFileNotUploadedException.php	100%	100%	100%	100%
OpenprojectGroupfolderSetupConflictException.php	100%	100%	100%	100%
OpenprojectResponseException.php	100%	100%	100%	100%
OpenprojectUnauthorizedUserException.php	0%	100%	0%	0%	21
integration_openproject/server/apps/integration_openproject/lib/Listener
BeforeGroupDeletedListener.php	100%	100%	100%	100%
BeforeNodeInsideOpenProjectGroupfilderChangedListener.php	0%	100%	0%	0%	46–48, 52–55, 57, 59, 62–63, 65, 67–70, 72–75, 77–79
BeforeUserDeletedListener.php	40%	100%	50%	37.50%	30, 38, 42–43, 45
LoadAdditionalScriptsListener.php	0%	100%	0%	0%	37–38, 46–47, 49, 51–52, 54
LoadSidebarScript.php	65.91%	100%	100%	64.29%	105, 77–88, 95, 98
OpenProjectReferenceListener.php	0%	100%	0%	0%	45–47, 54–55, 57, 59–60, 62–74
TermsOfServiceEventListener.php	0%	100%	0%	0%	41–42, 47–48, 50–51, 53–55, 58–62
UserChangedListener.php	0%	100%	0%	0%	34, 41–42, 45–50, 53
UserLoggedInEventListener.php	0%	100%	0%	0%	27, 35–36, 39, 42
integration_openproject/server/apps/integration_openproject/lib/Migration
Version2001Date20221213083550.php	0%	100%	0%	0%	30, 40–48, 50–58, 60–62, 64
Version20100Date20250820101358.php	0%	100%	0%	0%	38, 47–53, 56
Version2310Date20230116153411.php	0%	100%	0%	0%	29, 32–35, 37–62, 64–65, 67
Version2400Date20230504144300.php	0%	100%	0%	0%	30, 40–43
Version2640Date20240628114301.php	0%	100%	0%	0%	35, 47–49, 52–53, 56
Version2900Date20250718065820.php	0%	100%	0%	0%	22, 33–36, 38–39, 41–42, 45
integration_openproject/server/apps/integration_openproject/lib/Reference
WorkPackageReferenceProvider.php	51.67%	100%	25%	58.33%	100–101, 104, 108, 142, 150–151, 159, 37, 44, 51, 58–60, 87, 93–96, 99
integration_openproject/server/apps/integration_openproject/lib/Search
OpenProjectSearchProvider.php	0%	100%	0%	0%	100–102, 104–106, 109–110, 112–113, 116–125, 127–131, 52–55, 62, 69, 77, 79, 82, 89–90, 93–97, 99
OpenProjectSearchResultEntry.php	100%	100%	100%	100%
integration_openproject/server/apps/integration_openproject/lib/Service
DatabaseService.php	42.31%	100%	60%	40.43%	108–112, 114, 63–76, 78–85
DirectDownloadService.php	88.46%	100%	100%	87.50%	62–63, 65
DirectUploadService.php	42.86%	100%	66.67%	40%	101, 62–65, 67–75, 95
OauthService.php	100%	100%	100%	100%
OpenProjectAPIService.php	76.52%	100%	78.87%	76.33%	1005–1006, 1008,

nabim777 · 2026-07-31T06:35:09Z

+		$oauthService = $this->getOauthServiceMock($clientMapperMock);
+
+		$result = $oauthService->setClientRedirectUri(1, $client->getRedirectUri());
+		$this->assertEquals(true, $result);


Suggested change

$this->assertEquals(true, $result);

$this->assertTrue($result);

nabim777 · 2026-07-31T06:35:29Z

+		$oauthService = $this->getOauthServiceMock($clientMapperMock);
+
+		$result = $oauthService->setClientRedirectUri(1, $client->getRedirectUri());
+		$this->assertEquals(false, $result);


Suggested change

$this->assertEquals(false, $result);

$this->assertFalse($result);

nabim777 · 2026-07-31T06:50:15Z

+		$oauthService = $this->getOauthServiceMock($clientMapperMock);
+
+		$clientInfo = $oauthService->createNcOauthClient($client->getName(), $client->getRedirectUri());
+		$this->assertEquals($expectedClient, $clientInfo);


Suggested change

$this->assertEquals($expectedClient, $clientInfo);

$this->assertSame($expectedClient, $clientInfo);

need to do strict assertion 👍

nabim777 · 2026-07-31T07:06:06Z

+		$client->setClientIdentifier('randomString');
+		$client->setSecret('randomString');


Why are these values the same? Are they supposed to be different?

because we are mocking random generate method to return randomString.

but it can be anything here. secrets won't be used in the test

I was a bit confused because both values are the same.

If the specific values don't matter for this test, could we use different strings instead? It would make it clearer that clientIdentifier and secret are separate values.

I don't think so, because this a test client for assertion and we are mocking generate method which will always return same.

test(php): add phpunit tests for OauthService

4451bba

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

saw-jan self-assigned this Jul 29, 2026

saw-jan marked this pull request as ready for review July 30, 2026 04:49

saw-jan requested review from Ashim-Stha, Kharonus, NobodysNightmare, ba1ash, dominic-braeunlein, individual-it, julien-nc, lindenthal, nabim777, psatyal and wielinde as code owners July 30, 2026 04:49

Merge branch 'master' into test/phpunit-oauth-service

73ae4c8

Ashim-Stha reviewed Jul 31, 2026

View reviewed changes

Comment thread tests/lib/Service/OauthServiceTest.php

saw-jan requested a review from Ashim-Stha July 31, 2026 06:14

nabim777 reviewed Jul 31, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test(php): add phpunit tests for OauthService - #1131

test(php): add phpunit tests for OauthService#1131
saw-jan wants to merge 2 commits into
masterfrom
test/phpunit-oauth-service

saw-jan commented Jul 29, 2026

Uh oh!

github-actions Bot commented Jul 31, 2026

Uh oh!

Uh oh!

nabim777 Jul 31, 2026

Uh oh!

nabim777 Jul 31, 2026

Uh oh!

nabim777 Jul 31, 2026

Uh oh!

saw-jan Jul 31, 2026

Uh oh!

nabim777 Jul 31, 2026

Uh oh!

saw-jan Jul 31, 2026

Uh oh!

saw-jan Jul 31, 2026

Uh oh!

nabim777 Jul 31, 2026

Uh oh!

saw-jan Jul 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	$this->assertEquals(true, $result);
	$this->assertTrue($result);

	$this->assertEquals(false, $result);
	$this->assertFalse($result);

	$this->assertEquals($expectedClient, $clientInfo);
	$this->assertSame($expectedClient, $clientInfo);

		$client->setClientIdentifier('randomString');
		$client->setSecret('randomString');

Uh oh!

Conversation

saw-jan commented Jul 29, 2026

Description

Related Issue or Workpackage

Types of changes

Checklist:

Uh oh!

github-actions Bot commented Jul 31, 2026

PHP Code Coverage

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants