-
Notifications
You must be signed in to change notification settings - Fork 27
Add MultimodalChatWithToolsProvider #400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
0568acb
Add MultimodalChatWithToolsProvider
lukasdotcom 60ee11d
Add settings for multimodal providers and limit use the new file opti…
lukasdotcom 9c0c924
support multimodal chat outputs
lukasdotcom 0b591c1
Handle history for attachments correctly
lukasdotcom a173a2c
Support pdfs by converting them to images
lukasdotcom 1808448
Support files specified in history by task id directly as needed for …
lukasdotcom 1902b7f
Add more validation and handle null userid
lukasdotcom 986e583
add filesize limit for analyzeimage back and skip historical file con…
lukasdotcom 6c1ebeb
drop imagick parsing of pdfs
lukasdotcom 0f848f8
Add note about real urls
lukasdotcom 3bc687b
Merge branch 'main' into multimodal-provider
lukasdotcom File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| /** | ||
| * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors | ||
| * SPDX-License-Identifier: AGPL-3.0-or-later | ||
| */ | ||
|
|
||
| namespace OCA\OpenAi\Migration; | ||
|
|
||
| use Closure; | ||
| use OCA\OpenAi\AppInfo\Application; | ||
| use OCP\IAppConfig; | ||
| use OCP\Migration\IOutput; | ||
| use OCP\Migration\SimpleMigrationStep; | ||
|
|
||
| class Version040600Date20260708151000 extends SimpleMigrationStep { | ||
|
|
||
| public function __construct( | ||
| private IAppConfig $appConfig, | ||
| ) { | ||
| } | ||
|
|
||
| /** | ||
| * @param IOutput $output | ||
| * @param Closure $schemaClosure | ||
| * @param array $options | ||
| */ | ||
| public function postSchemaChange(IOutput $output, Closure $schemaClosure, array $options): void { | ||
| $unset = '__unset__'; | ||
| $newValue = $this->appConfig->getValueString(Application::APP_ID, 'multimodal_image_enabled', $unset); | ||
| if ($newValue !== $unset) { | ||
| return; | ||
| } | ||
|
|
||
| $oldValue = $this->appConfig->getValueString(Application::APP_ID, 'analyze_image_provider_enabled', $unset); | ||
| if (!in_array($oldValue, ['0', '1'], true)) { | ||
| return; | ||
| } | ||
|
|
||
| $this->appConfig->setValueString(Application::APP_ID, 'multimodal_image_enabled', $oldValue); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shifts the default state from 0 to 1, I think. Ideally, if it has been unset previously, we should set it to what used to be the default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Back when analyze image was created I don't think IONOS had a model with support for image input, but now that they do I think it might be worth it to change the default to on instead of off.