Skip to content

chore: update psalm and nextcloud/coding-standard #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oleksandr-nc merged 2 commits into from
Jul 28, 2026
Merged

chore: update psalm and nextcloud/coding-standard #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca1ab8e
chore: update psalm to 6.16 and refresh the baseline
oleksandr-nc Jul 27, 2026
8a80855
chore: update nextcloud/coding-standard to 1.5 and apply cs:fix
oleksandr-nc Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@
"minimum-stability": "stable",
"require-dev": {
"nextcloud/ocp": "dev-master",
"nextcloud/coding-standard": "^1.1",
"nextcloud/coding-standard": "^1.5",
"phpunit/phpunit": "^10",
"psalm/phar": "6.7.x"
"psalm/phar": "^6.16"
},
"require": {
"php": ">=8.2.0"
Expand Down
159 changes: 27 additions & 132 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion lib/AppInfo/Application.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
use OCA\Jira\Search\JiraSearchProvider;
use OCP\AppFramework\App;
use OCP\AppFramework\Bootstrap\IBootContext;

use OCP\AppFramework\Bootstrap\IBootstrap;
use OCP\AppFramework\Bootstrap\IRegistrationContext;
use OCP\Collaboration\Reference\RenderReferenceEvent;
Expand Down
1 change: 0 additions & 1 deletion lib/BackgroundJob/CheckOpenTickets.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
use OCA\Jira\Service\JiraAPIService;
use OCP\AppFramework\Utility\ITimeFactory;
use OCP\BackgroundJob\TimedJob;

use Psr\Log\LoggerInterface;

/**
Expand Down
1 change: 0 additions & 1 deletion lib/Controller/ConfigController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
use OCP\AppFramework\Http\RedirectResponse;
use OCP\IConfig;
use OCP\IL10N;

use OCP\IRequest;
use OCP\IURLGenerator;
use OCP\PreConditionNotMetException;
Expand Down
1 change: 0 additions & 1 deletion lib/Controller/JiraAPIController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
use OCP\AppFramework\Controller;
use OCP\AppFramework\Http\DataDisplayResponse;
use OCP\AppFramework\Http\DataResponse;

use OCP\IRequest;

class JiraAPIController extends Controller {
Expand Down
1 change: 0 additions & 1 deletion lib/Dashboard/JiraWidget.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
use OCP\Dashboard\IWidget;
use OCP\IL10N;
use OCP\IURLGenerator;

use OCP\Util;

class JiraWidget implements IWidget {
Expand Down
1 change: 0 additions & 1 deletion lib/Dashboard/JiraWidgetWithFilter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
use OCP\Dashboard\IWidget;
use OCP\IL10N;
use OCP\IURLGenerator;

use OCP\Util;

class JiraWidgetWithFilter implements IWidget {
Expand Down
1 change: 0 additions & 1 deletion lib/Notification/Notifier.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ public function prepare(INotification $notification, string $languageCode): INot
->setIcon($this->url->getAbsoluteURL($this->url->imagePath(Application::APP_ID, 'app-dark.svg')));
//->setIcon($this->url->getAbsoluteURL($iconUrl));
return $notification;

default:
// Unknown subject => Unknown notification => throw
throw new UnknownNotificationException();
Expand Down
1 change: 0 additions & 1 deletion lib/Reference/JiraReferenceProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
use OCP\Collaboration\Reference\Reference;
use OCP\IConfig;
use OCP\IL10N;

use OCP\IURLGenerator;
use Throwable;

Expand Down
2 changes: 0 additions & 2 deletions lib/Service/NetworkService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
use GuzzleHttp\Exception\ClientException;
use GuzzleHttp\Exception\ServerException;
use OCA\Jira\AppInfo\Application;

use OCP\Http\Client\IClient;
use OCP\Http\Client\IClientService;
use OCP\Http\Client\IResponse;
Expand All @@ -21,7 +20,6 @@
use OCP\PreConditionNotMetException;
use OCP\Security\ICrypto;
use Psr\Log\LoggerInterface;

use Throwable;

/**
Expand Down
1 change: 0 additions & 1 deletion lib/Settings/Admin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
use OCP\AppFramework\Http\TemplateResponse;
use OCP\AppFramework\Services\IInitialState;
use OCP\IConfig;

use OCP\Settings\ISettings;

class Admin implements ISettings {
Expand Down
1 change: 0 additions & 1 deletion lib/Settings/Personal.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
use OCP\AppFramework\Http\TemplateResponse;
use OCP\AppFramework\Services\IInitialState;
use OCP\IConfig;

use OCP\Settings\ISettings;

class Personal implements ISettings {
Expand Down
5 changes: 1 addition & 4 deletions tests/psalm-baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<files psalm-version="6.7.1@a2f190972555ea01b0cfcc1913924d6c5fc1a64e">
<files psalm-version="6.16.1@f1f5de594dc76faf8784e02d3dc4716c91c6f6ac">
<file src="lib/Controller/ConfigController.php">
<InvalidArgument>
<code><![CDATA[$expiresAt]]></code>
Expand Down Expand Up @@ -28,8 +28,5 @@
<InvalidArgument>
<code><![CDATA[$expiresAt]]></code>
</InvalidArgument>
<InvalidOperand>
<code><![CDATA[$key]]></code>
</InvalidOperand>
</file>
</files>
Loading
Loading