chore: adjust comment in Dockerfile regarding RTX5090 support#316
Open
kyteinsky wants to merge 1 commit into
Open
chore: adjust comment in Dockerfile regarding RTX5090 support#316kyteinsky wants to merge 1 commit into
kyteinsky wants to merge 1 commit into
Conversation
Signed-off-by: kyteinsky <kyteinsky@gmail.com> Assisted-by: Github Copilot:claude-sonnet-4-6
marcelklehr
reviewed
Jun 17, 2026
| # Real cubins for all shipping GPU generations through Blackwell (sm_100), | ||
| # plus one forward-compatible PTX target to keep wheel size manageable. | ||
| # CMAKE_CUDA_ARCHITECTURES is intentionally not set here. llama.cpp's CMake | ||
| # selects sensible defaults based on the detected CUDA toolkit version: |
Member
There was a problem hiding this comment.
mmh, but this is at build time, right? so it does not depend on the CUDA version that the admin has but on the CUDA version of the CUDA_DEVEL_IMAGE, correct?
Contributor
Author
There was a problem hiding this comment.
yep, and we depend on llama.cpp to make the correct choice of cubins to bake in, so we don't have to check and adjust it when the cuda version changes.
we could but it already exists so I didn't bother.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assisted-by: Github Copilot:claude-sonnet-4-6
fixes: #305
🤖 AI (if applicable)