fix: import - #5386
Open
SebastianKrupinski wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
SebastianKrupinski
marked this pull request as draft
June 13, 2026 18:21
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
SebastianKrupinski
force-pushed
the
fix/contacts-import
branch
from
June 24, 2026 19:19
2c9c13f to
2dd6070
Compare
SebastianKrupinski
added
3. to review
SebastianKrupinski
marked this pull request as ready for review
June 24, 2026 19:32
7 tasks
| <template #icon> | ||
| <Upload :size="20" /> | ||
| </template> | ||
| {{ n('contacts', 'Import contacts', 'Import contacts', entries.length) }} |
Member
There was a problem hiding this comment.
Suggested change
| {{ n('contacts', 'Import contacts', 'Import contacts', entries.length) }} | |
| {{ n('contacts', 'Import contact', 'Import %n contacts', entries.length) }} |
https://docs.nextcloud.com/server/latest/developer_manual/basics/translations.html#correct-plurals
GVodyanov
reviewed
Jul 30, 2026
| &__file-list { | ||
| display: flex; | ||
| flex-direction: column; | ||
| gap: 12px; |
Contributor
There was a problem hiding this comment.
Suggested change
| gap: 12px; | |
| gap: calc(var(--default-grid-baseline) * 3); |
Also for the other occurences
GVodyanov
reviewed
Jul 30, 2026
| async resolveTarget(entry) { | ||
| const { file, addressbookId } = entry | ||
|
|
||
| if (addressbookId !== 'new') { |
Contributor
There was a problem hiding this comment.
what if someone has an addressbook named new?
Contributor
I can see the vision with the two columns but the weird padding that nc-vue ads makes it look not great. I would suggest stretching out the inputs to be full column width and adding a gap between the columns. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary