Skip to content

enh(circle-details): adjust action buttons on edit mode and cropper dialog#5349

Open
cristianscheid wants to merge 1 commit into
mainfrom
enh/noid/circle-details-edit-mode
Open

enh(circle-details): adjust action buttons on edit mode and cropper dialog#5349
cristianscheid wants to merge 1 commit into
mainfrom
enh/noid/circle-details-edit-mode

Conversation

@cristianscheid
Copy link
Copy Markdown
Member

@cristianscheid cristianscheid commented May 23, 2026

Summary

Screenshots

Screenshot from 2026-05-23 09-26-37 Screenshot from 2026-05-23 09-27-48
Screenshot from 2026-05-23 09-27-01 image

@codecov
Copy link
Copy Markdown

codecov Bot commented May 23, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/components/CircleDetails.vue 0.00% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

@cristianscheid cristianscheid force-pushed the enh/noid/circle-details-edit-mode branch from ebc93b8 to f3390b2 Compare May 23, 2026 12:43
@cristianscheid cristianscheid self-assigned this May 23, 2026
@cristianscheid cristianscheid added enhancement New feature or request 3. to review Waiting for reviews labels May 23, 2026
@cristianscheid
Copy link
Copy Markdown
Member Author

cristianscheid commented May 23, 2026

As a side note, I was able to make the dialog not expand on mobile and look like it does for bigger screens, but that required a bunch of modifications on NcDialog component's style, so I left it out of this PR.

  • For reference, in case we are fine with those modifications, I was able to achieve it with this CSS :
<style lang="scss">
.circle-avatar-cropper-dialog .modal-wrapper--small .modal-container {
	width: 324px !important;
}

@media only screen and (max-width: 512px) {
    .circle-avatar-cropper-dialog .modal-wrapper--small .modal-container {
        height: fit-content !important;
        position: absolute !important;
        top: 50% !important;
        transform: translateY(-50%) !important;
        border-radius: var(--border-radius-large) !important;
		
		.modal-container__content .dialog__name {
			text-align: center !important;
		}
    }
}
</style>
  • With styles above, it looked like this:
Screenshot from 2026-05-23 09-29-02

@cristianscheid cristianscheid force-pushed the enh/noid/circle-details-edit-mode branch from f3390b2 to c41fb0e Compare May 23, 2026 12:50
Copy link
Copy Markdown
Member

@kra-mo kra-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in case we are fine with those modifications

No, I understand, if it's overcomplicating it, then it's not worth it.

Then my only ask is to vertically center the cropping widget in the mobile dialog.

The rest looks really nice, thanks!

…ialog

Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
@cristianscheid cristianscheid force-pushed the enh/noid/circle-details-edit-mode branch from c41fb0e to a5009ed Compare May 25, 2026 11:29
@cristianscheid
Copy link
Copy Markdown
Member Author

Then my only ask is to vertically center the cropping widget in the mobile dialog.

Done. Screenshots on main comment updated.

@cristianscheid cristianscheid requested a review from kra-mo May 25, 2026 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants