enh(circle-details): adjust action buttons on edit mode and cropper dialog#5349
Open
cristianscheid wants to merge 1 commit into
Open
enh(circle-details): adjust action buttons on edit mode and cropper dialog#5349cristianscheid wants to merge 1 commit into
cristianscheid wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
ebc93b8 to
f3390b2
Compare
Member
Author
f3390b2 to
c41fb0e
Compare
kra-mo
requested changes
May 23, 2026
Member
kra-mo
left a comment
There was a problem hiding this comment.
in case we are fine with those modifications
No, I understand, if it's overcomplicating it, then it's not worth it.
Then my only ask is to vertically center the cropping widget in the mobile dialog.
The rest looks really nice, thanks!
…ialog Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
c41fb0e to
a5009ed
Compare
Member
Author
Done. Screenshots on main comment updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Screenshots