feat: automatically create a teamfolder upon team creation - #2675
Open
stediefan wants to merge 1 commit into
Open
feat: automatically create a teamfolder upon team creation#2675stediefan wants to merge 1 commit into
stediefan wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
stediefan
force-pushed
the
feature/teams-auto-folder-creation
branch
2 times, most recently
from
July 24, 2026 09:47
eea615b to
a52e6da
Compare
7 tasks
CarlSchwan
reviewed
Jul 24, 2026
feat: introduce a function to upgrade existing teams to include the special teamfolder feat: add settings page to configure a default quota for new teamfolders Assisted by: GitHub Copilot:Claude Sonnet 5 Assisted by: GitHub Copilot:GPT-5.6 Terra Assisted by: GitHub Copilot:Kimi K2.7 Code Signed-off-by: Stefan Dietrich <5716289+stediefan@users.noreply.github.com>
stediefan
force-pushed
the
feature/teams-auto-folder-creation
branch
from
July 27, 2026 08:20
a52e6da to
6ab835a
Compare
artonge
reviewed
Jul 30, 2026
| } | ||
| } | ||
|
|
||
| private function requireMember(string $circleId): void { |
Contributor
There was a problem hiding this comment.
Just to make it more explicit. Same with the two other methods.
Suggested change
| private function requireMember(string $circleId): void { | |
| private function assertAuthenticatedUserIsMember(string $circleId): void { |
| * @return list<string> | ||
| */ | ||
| private function filterExistingCircleColumns(array $fields): array { | ||
| static $columns = null; |
Contributor
There was a problem hiding this comment.
Is a static variable really needed? IIRC, we are trying to get rid of them.
| * @param list<string> $fields | ||
| * @return list<string> | ||
| */ | ||
| private function filterExistingCircleColumns(array $fields): array { |
Contributor
There was a problem hiding this comment.
What's the goal of this method?
| } | ||
|
|
||
| $circle = $event->getCircle(); | ||
| $provider->unlinkTeamFolder($circle->getSingleId()); |
Contributor
There was a problem hiding this comment.
Will the team folder be visible to an admin to be deleted afterward?
| * | ||
| * Implementation: {@see TeamFolderService} in the circles app. | ||
| */ | ||
| interface TeamFolderPolicy { |
Contributor
There was a problem hiding this comment.
Suggested change
| interface TeamFolderPolicy { | |
| interface ITeamFolderPolicy { |
| * The Groupfolders provider owns the durable `team_circle_id` linkage. Circles | ||
| * never persists a Groupfolders identifier. | ||
| */ | ||
| class TeamFolderService implements TeamFolderPolicy { |
Contributor
There was a problem hiding this comment.
Suggested change
| class TeamFolderService implements TeamFolderPolicy { | |
| class TeamFolderPolicy implements ITeamFolderPolicy { |
Comment on lines
+24
to
+27
| * The `@nextcloud/files` Node class exposes the same public interface, but | ||
| * TypeScript requires us to keep the private fields when using the class | ||
| * type directly. Using our own interface keeps the template code simple. | ||
| */ |
Contributor
There was a problem hiding this comment.
I am not sure to get that comment. What was the problem?
I think nowadays, we are using the INode, IFile, IFolder interface instead of the classes. Maybe that would help.
Comment on lines
+29
to
+35
| function bytesToMb(bytes: number): string { | ||
| if (bytes === 0) { | ||
| return '0' | ||
| } | ||
| const mb = bytes / BYTES_PER_MB | ||
| return String(parseFloat(mb.toFixed(2))) | ||
| } |
Contributor
There was a problem hiding this comment.
Maybe this function can help here: https://nextcloud-libraries.github.io/nextcloud-files/functions/index.formatFileSize.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: introduce a function to upgrade existing teams to include the special teamfolder
feat: add settings page to configure a default quota for new teamfolders
Assisted by: GitHub Copilot:Claude Sonnet 5
Assisted by: GitHub Copilot:GPT-5.6 Terra
Assisted by: GitHub Copilot:Kimi K2.7 Code
Summary
This is a aggregated feature that integrates teams with teamfolders. The teams feature aims to provide a space for team owned apps. This provides the base as the linked groupfolder is the proposed solution.
TODO
Checklist
The newly introduced feature to set a default Quota for the auto created folders:
see todo
no
3. to review, feature component)stable32)AI (if applicable)