Skip to content

fix(css): Shorter events overlapping#8489

Open
pallavibakale wants to merge 1 commit into
nextcloud:mainfrom
pallavibakale:fix/shorter-events-overlapping-8229
Open

fix(css): Shorter events overlapping#8489
pallavibakale wants to merge 1 commit into
nextcloud:mainfrom
pallavibakale:fix/shorter-events-overlapping-8229

Conversation

@pallavibakale

@pallavibakale pallavibakale commented Jun 11, 2026

Copy link
Copy Markdown

Fixes: #8229

Removed min-height for shorter events to avoid overlapping events and a better view.
Screenshot attached:

Before fix:

  1. With 1 hour density setting:
image
  1. With 10 mins density setting:
image

After fix:

  1. With 1 hour density setting:
Screenshot 2026-06-11 194333
  1. With 10 mins density setting:
image

@pallavibakale pallavibakale changed the title fix(css): Shorter events overlapping #8229 fix(css): Shorter events overlapping Jun 12, 2026
@SebastianKrupinski

Copy link
Copy Markdown
Contributor

Hi @pallavibakale

Thanks for the PR. I will have some one from the design team review the changes.

@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Signed-off-by: pallavibakale <pallavibakale09@gmail.com>
@pallavibakale pallavibakale force-pushed the fix/shorter-events-overlapping-8229 branch from 5547e6e to 6872e22 Compare June 12, 2026 14:38
@SebastianKrupinski

Copy link
Copy Markdown
Contributor

@nimishavijay @kra-mo

Please have a look at the proposed changes

@nimishavijay

Copy link
Copy Markdown
Member

Good idea! However, I'm not sure if this would be accessible if the min-height is completely removed. Since they are all clickable items, the minimum height should be 24px to make sure it remains accessible (especially important on mobile), and we should also try to center the text in that little container so it doesn't appear cut off as much as possible :)

@pallavibakale

Copy link
Copy Markdown
Author

@nimishavijay I agree on keeping the minimum height to 24px. The text is vertically centered, it appears to be clipped when there is no minimum height set. The padding adds the extra space, without padding the text sticks to container which is not recommended.
Could you suggest some other ways to resolve this issue?

@nimishavijay

Copy link
Copy Markdown
Member

Just quickly checked with the dev tools and using a 24px min-height doesn't cut off any text, so we can do ahead with that :) the center alignment is too negligible in this case, so we don't have to necessarily adjust it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Short events are not shown correctly in the week view which leads to overlapping events

3 participants