Skip to content

fix: e2ee key creation#16944

Open
alperozturk96 wants to merge 7 commits intomasterfrom
fix/e2ee-key-creation
Open

fix: e2ee key creation#16944
alperozturk96 wants to merge 7 commits intomasterfrom
fix/e2ee-key-creation

Conversation

@alperozturk96
Copy link
Copy Markdown
Collaborator

@alperozturk96 alperozturk96 commented Apr 30, 2026

No description provided.

@alperozturk96
Copy link
Copy Markdown
Collaborator Author

alperozturk96 commented Apr 30, 2026

/backport to stable-33.1.x

alperozturk96
alperozturk96 commented Apr 30, 2026
View reviewed changes
Comment thread app/src/main/java/com/owncloud/android/operations/RemoveRemoteEncryptedFileOperation.kt

parentFolder.setE2eCounter(metadata.metadata.counter)
val storageManager = FileDataStorageManager(user, context.contentResolver)
storageManager.saveFile(parentFolder)
Copy link
Copy Markdown
Collaborator Author

@alperozturk96 alperozturk96 Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Save counter after delete

@alperozturk96 alperozturk96 force-pushed the fix/e2ee-key-creation branch 2 times, most recently from e1f41de to f74a8ac Compare April 30, 2026 13:28
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 30, 2026

APK file: https://github.com/nextcloud/android/actions/runs/25168095537/artifacts/6731745708
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96 alperozturk96 force-pushed the fix/e2ee-key-creation branch from f74a8ac to 650cfd5 Compare May 5, 2026 08:52
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

APK file: https://github.com/nextcloud/android/actions/runs/25366915880/artifacts/6802840244
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96 alperozturk96 force-pushed the fix/e2ee-key-creation branch from 650cfd5 to 4e74f28 Compare May 7, 2026 06:47
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

APK file: https://github.com/nextcloud/android/actions/runs/25480530268/artifacts/6848743513
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96 alperozturk96 force-pushed the fix/e2ee-key-creation branch from 4e74f28 to 619c01d Compare May 7, 2026 07:26
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

APK file: https://github.com/nextcloud/android/actions/runs/25482165977/artifacts/6849826351
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96 alperozturk96 force-pushed the fix/e2ee-key-creation branch from 619c01d to 774f415 Compare May 7, 2026 08:35
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

APK file: https://github.com/nextcloud/android/actions/runs/25485144828/artifacts/6850730663
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96
wip
5bafd04 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
2576931 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
a003b26 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
e978763 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
a3f9af0 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

# Conflicts:
#	gradle/libs.versions.toml
@alperozturk96
wip
2e07981 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the fix/e2ee-key-creation branch from 4f4e4c1 to 2e07981 Compare May 7, 2026 12:10
@alperozturk96
fix checksum generation
81d6170 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 added this to the Nextcloud App 33.1.1 milestone May 7, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

APK file: https://github.com/nextcloud/android/actions/runs/25496839876/artifacts/6857442720
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

Codacy

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness6767
Dodgy code216216
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3434
Performance4242
Security1616
Total420420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

3. to review backport-request

Projects

None yet

Milestone

Nextcloud App 33.1.1

Development

Successfully merging this pull request may close these issues.

1 participant

@alperozturk96