Skip to content

Animate sidebar tabs like navigation entries - #8793

Open
jancborchardt wants to merge 1 commit into
mainfrom
feat/sidebar-tabs-animation
Open

Animate sidebar tabs like navigation entries#8793
jancborchardt wants to merge 1 commit into
mainfrom
feat/sidebar-tabs-animation

Conversation

@jancborchardt

@jancborchardt jancborchardt commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Same as #8685 but for the sidebar tabs.

☑️ Resolves

🖼️ Screenshots

🏚️ Before

Screencast.From.2026-07-30.07-43-34.webm

🏡 After

Screencast.From.2026-07-30.17-02-40.webm

Just for the record: Previous versions with different active / highlight color

Screencast.From.2026-07-30.07-33-28.webm

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@jancborchardt jancborchardt self-assigned this Jul 30, 2026
@jancborchardt jancborchardt added 3. to review Waiting for reviews papercut Annoying recurring issue with possibly simple fix. design Design, UX, interface and interaction design AI assisted This PR contains AI-assisted commits labels Jul 30, 2026
@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 53.81%. Comparing base (0dad83c) to head (d97acc3).

Files with missing lines Patch % Lines
src/components/NcAppSidebar/NcAppSidebarTabs.vue 97.43% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8793      +/-   ##
==========================================
+ Coverage   53.31%   53.81%   +0.50%     
==========================================
  Files         109      112       +3     
  Lines        3697     3837     +140     
  Branches     1083     1121      +38     
==========================================
+ Hits         1971     2065      +94     
- Misses       1472     1504      +32     
- Partials      254      268      +14     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kra-mo kra-mo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, with the bounce and crossfade of the icons too. Although how come the hover color is different from the selection color?

@jancborchardt

Copy link
Copy Markdown
Contributor Author

Although how come the hover color is different from the selection color?

@kra-mo I was experimenting a bit with tinting, and having them different. But am open to change it. It would probably indeed look more seamless if it's all the same color. In that case should it be grey or tinted?

@kra-mo

kra-mo commented Jul 30, 2026

Copy link
Copy Markdown
Member

@jancborchardt I like the tint :)

@jancborchardt

Copy link
Copy Markdown
Contributor Author

@kra-mo indeed it looks much better with tint across the board. :) Adjusted and updated the screencast in the original post.

Assisted-by: ClaudeCode:claude-opus-4-8
Signed-off-by: Jan C. Borchardt <925062+jancborchardt@users.noreply.github.com>
@jancborchardt
jancborchardt force-pushed the feat/sidebar-tabs-animation branch from 50f79b8 to d97acc3 Compare July 30, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews AI assisted This PR contains AI-assisted commits design Design, UX, interface and interaction design papercut Annoying recurring issue with possibly simple fix.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants