fix(NcDateTimePicker): improve some usability issues#8479
Conversation
8bb1b77 to
785aa4a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8479 +/- ##
=======================================
Coverage 54.55% 54.55%
=======================================
Files 106 106
Lines 3439 3439
Branches 1002 1003 +1
=======================================
Hits 1876 1876
Misses 1322 1322
Partials 241 241 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Grigory V <scratchx@gmx.com>
c8041c7 to
58cbf03
Compare
susnux
left a comment
There was a problem hiding this comment.
it would be easier if you could split the PR into individual changes.
e.g. one for the color and one for the scrolling as they are unrelated
jancborchardt
left a comment
There was a problem hiding this comment.
Added icon to submit button
@GVodyanov can you show a screenshot of that? Because the "clock" button already only has an icon but no text, and could use some text – namely "Set time" (right?).
It’s most important for a button to have text. Icons are secondary, and very often not needed.
No in this case it was just empty, it's in the screenshot in the PR description at the very bottom of the second row. I can totally add text too though yeah. |
Fixes a few small issues:
🖼️ Screenshots
🚧 Tasks
🏁 Checklist
stable8for maintained Vue 2 version or not applicable