Skip to content

chore: add ESLint and fix issues detected#1042

Merged
susnux merged 3 commits into
mainfrom
eslint
Jul 3, 2026
Merged

chore: add ESLint and fix issues detected#1042
susnux merged 3 commits into
mainfrom
eslint

Conversation

@susnux

@susnux susnux commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Add ESLint so this also gets linted.

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

susnux added 2 commits July 2, 2026 18:38
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux requested review from max-nextcloud and skjnldsv July 2, 2026 16:39
@susnux susnux added the 3. to review Waiting for reviews label Jul 2, 2026
Comment thread package.json
"cypress-vite": "^1.10.2",
"eslint": "^10.6.0",
"globals": "^17.7.0",
"jiti": "^2.7.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is needed for the eslint.config.ts, right?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jiti is needed to allow Typescript config yes :)

@max-nextcloud max-nextcloud left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this. ❤️

One small question / remark (see above).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux

susnux commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

(fixed the wrongly "fixed" cypress tests where it tried to import .ts from dist/)

@susnux susnux merged commit a338047 into main Jul 3, 2026
10 checks passed
@susnux susnux deleted the eslint branch July 3, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants