Repository navigation
Version the next release 4.1 - #43
Merged
Merged
Conversation
The release that adds bonding (#34, #35) and the GATT status on failures (#36) adds public API, so it is a minor version. The release workflow now stamps 4.1.yyMM.<run number + 100>, VersionPrefix moves to 4.1.0 for local builds, the release notes name 4.1, and the README's install example and CI description follow. AssemblyVersion stays 4.0.0.0: it is pinned for the strong-named net481 binding, for the reason recorded in the project file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release that adds bonding (#34, #35) and the GATT status on failures (#36) adds public API, so it is versioned 4.1.
Changes
.github/workflows/release.yml: the version stamp moves from4.0.yyMM.<run number + 100>to4.1.yyMM.<run number + 100>, along with the header comment that describes it. Nothing else in the workflow changes. The comment about the +100 offset and 4.0.2610.91 is kept as it is: it records why the offset exists.DSoft.System.BluetoothLe.csproj:VersionPrefixmoves from 4.0.1 to 4.1.0, which only affects local builds because CI passesVersion. ThePackageReleaseNotesparagraph headed "Unreleased" is now headed "4.1 - adds bonding and the GATT status on failures".README.md: the install example is nowVersion="4.1.*", and the CI section describes the 4.1 stamp.Not changed, on purpose
AssemblyVersionstays 4.0.0.0. It is pinned so that the strong-named assembly's identity does not move on every release, which would force binding redirects on net481. The project file records why. Raising it to 4.1.0.0 is possible, but it is a separate decision with that cost.Merge order
The order relative to #42 doesn't matter. This branch merges cleanly with #42's branch,
feature/bond-request, in either order. It renames only the first line of the release-notes paragraph, and #42 adds lines further down.Verification
No code changes, so there is nothing to test on hardware, and there is no test project. CI builds the change.