chore: bump subscriptions v2.2.2 for CDN deploy - #34
Merged
Conversation
- Trigger CDN redeploy with NEV-1545 fix (alias key resolution) - Previous deploy skipped because v2.2.1 already existed in S3 Refs: NEV-1545
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| { | ||
| "name": "@nevent/subscriptions", | ||
| "version": "2.2.1", | ||
| "version": "2.2.2", |
There was a problem hiding this comment.
Bug: The Sentry release version is hardcoded to @nevent/subscriptions@2.2.1 and was not updated to 2.2.2 to match the package.json version bump.
Severity: MEDIUM
Suggested Fix
Update the hardcoded release string in packages/subscriptions/src/newsletter-widget.ts to match the new package version: release: '@nevent/subscriptions@2.2.2'. For a more robust long-term solution, consider automating this version replacement during the build process, for example by using an environment variable or a Vite plugin to read the version from package.json.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: packages/subscriptions/package.json#L3
Potential issue: The `release` version for Sentry reporting is hardcoded as
`@nevent/subscriptions@2.2.1` in `packages/subscriptions/src/newsletter-widget.ts`.
However, this pull request updates the package version to `2.2.2` in `package.json`.
Since the build process does not automatically substitute this string, all errors from
the new v2.2.2 deployment will be incorrectly attributed to v2.2.1 in Sentry. This will
break error attribution and version tracking, making it difficult to correlate bugs with
the specific release that introduced them and impacting production observability.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version bump to trigger CDN deploy. v2.2.1 was skipped because it already existed in S3. Contains NEV-1545 fix for newsletter widget field key alias resolution.