feat(workflow): add workflow auditor + scan-workflow CLI (v0.6.0)#4
Merged
Conversation
Adds a parallel scanning surface for ComfyUI workflow files (JSON exports and PNG images with workflow metadata embedded in tEXt/zTXt/iTXt chunks). Workflows ship more freely than custom_nodes (Civitai, Reddit, Discord) and carry their own attack surface: malicious widget values, embedded Python in ExecutePython-style nodes, exfiltration URLs, references to compromised custom_nodes. New module src/nodesafe/workflow/ with: - Workflow + WorkflowNode dataclasses normalizing UI form and prompt form - Parser for JSON and PNG (stdlib struct + zlib, no Pillow dep) - WL1: URL membership check over widget-value URLs (reuses malicious_urls.txt) - WL2: Aho-Corasick over widget-value text (reuses patterns.json) - WorkflowScanner orchestrator emitting the same Report shape as code scanning CLI gains 'nodesafe scan-workflow TARGET' with --format, --fail-on, --config. - 19 new tests (parser, extractors, analyzers, CLI), 106/106 total passing - ruff, ruff format, pyright all clean - no new runtime deps - bumps to v0.6.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a parallel scanning surface for ComfyUI workflow files (JSON exports
and PNG images with workflow metadata embedded in tEXt/zTXt/iTXt chunks).
Workflows ship more freely than custom_nodes (Civitai, Reddit, Discord)
and carry their own attack surface: malicious widget values, embedded
Python in ExecutePython-style nodes, exfiltration URLs, references to
compromised custom_nodes.
New module src/nodesafe/workflow/ with:
CLI gains 'nodesafe scan-workflow TARGET' with --format, --fail-on, --config.