refactor(assistant): inject TimeProvider and IdGenerator seams#32
Merged
Conversation
AssistantViewModel built chat message timestamps and ids by calling `Date()` and `UUID.randomUUID()` directly, hidden dependencies on the wall clock and the RNG that made those fields untestable. Introduce two small seams (`TimeProvider`, `IdGenerator`) with default production implementations, provide them as singletons from AppModule, and inject them into the ViewModel. Production behavior is unchanged. AssistantViewModelTest now passes deterministic fakes instead of leaning on the system clock and random UUIDs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AssistantViewModelbuilt chat message timestamps and ids by callingDate()andUUID.randomUUID()directly. Those are hidden dependencies on the wall clock and the RNG that left thetimestampLabelandidfields untestable. This PR introduces two small seams,TimeProviderandIdGenerator(each afun interfacewith a default production implementation), provides them as singletons fromAppModule, and injects them into the ViewModel.Rationale
The seams follow the dependency-injection style already used across the app (Hilt) and keep the ViewModel deterministic under test without changing production behavior:
SystemTimeProviderstill returnsDate()andUuidIdGeneratorstill returns a random UUID.java.time.Clockwas deliberately avoided becauseminSdkis 24 and it would require core-library desugaring.AssistantViewModelTestnow constructs the ViewModel with deterministic fakes (a fixed instant and sequential ids) instead of leaning on the system clock and random UUIDs.Verification
./gradlew ktlintCheck detekt testDebugUnitTest-> BUILD SUCCESSFUL./gradlew assembleDebug-> BUILD SUCCESSFULTest plan
AssistantViewModelTestgreen with injected fakesChecklist
refactor/).[Unreleased]. (No user-visible change.)